Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove component CSS class name default #545

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

javierjulio
Copy link
Member

@javierjulio javierjulio commented Oct 24, 2023

A component will no longer add a CSS class name by default.

This will be in a major (v2) release due to being a breaking change.

@javierjulio javierjulio self-assigned this Oct 24, 2023
@javierjulio javierjulio changed the title Remove component class name default Remove component CSS class name default Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22a71a3) 92.48% compared to head (c71cf7b) 92.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
- Coverage   92.48%   92.39%   -0.10%     
==========================================
  Files          17       17              
  Lines         466      460       -6     
==========================================
- Hits          431      425       -6     
  Misses         35       35              
Files Coverage Δ
lib/arbre/component.rb 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javierjulio javierjulio force-pushed the remove-component-class-name-default branch from 3989ca1 to c71cf7b Compare October 24, 2023 22:44
@javierjulio javierjulio merged commit 0d6927d into master Oct 24, 2023
22 checks passed
@javierjulio javierjulio deleted the remove-component-class-name-default branch October 24, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant