-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ActiveSupport 7.1 as default setup #537
Add ActiveSupport 7.1 as default setup #537
Conversation
6ce29c4
to
6e05c7e
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #537 +/- ##
=======================================
Coverage 92.52% 92.52%
=======================================
Files 17 17
Lines 468 468
=======================================
Hits 433 433
Misses 35 35 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with the suggestion for resolving the deprecation warning. If you know of other solutions please share. We'll remove the upper bound limit on dependencies as part of a separate change so this shouldn't be needed in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll have to rebase and resolve conflicts. I merged #539 to make future maintenance easier.
Please update the Dependabot config with an item for the new rails_70
directory.
60a19e0
to
22cac0a
Compare
- Move 7.0 Gemfile to the gemfiles folder
- Update changelog
22cac0a
to
708df54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I made this PR based on #314, so:
I ran
rake spec
with all Gemfiles, but got a Deprecation Warning that a didn't succeed in solving:One solution that I found is to define the config on
spec/rails/rails_spec_helper.rb
: