Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ActiveSupport 7.1 as default setup #537

Merged
merged 5 commits into from
Oct 7, 2023

Conversation

tomascco
Copy link
Contributor

@tomascco tomascco commented Oct 5, 2023

I made this PR based on #314, so:

  • Updated the "main" Gemfile to Rails 7.1
  • Moved the old Gemfile to the gemfiles folder
  • Updated all Gemfiles

I ran rake spec with all Gemfiles, but got a Deprecation Warning that a didn't succeed in solving:

DEPRECATION WARNING: Support for `config.active_support.cache_format_version = 6.1` has been deprecated and will be removed in Rails 7.2.

(called from <top (required)> at arbre/spec/rails/rails_spec_helper.rb:5)

One solution that I found is to define the config on spec/rails/rails_spec_helper.rb:

# from
Combustion.initialize! :action_controller,
                       :action_view

# to
Combustion.initialize! :action_controller, :action_view do # line 5
  config.active_support.cache_format_version = 7.1
end

@tomascco tomascco force-pushed the chore/support-rails-71 branch 2 times, most recently from 6ce29c4 to 6e05c7e Compare October 5, 2023 15:27
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5f9cc4e) 92.52% compared to head (708df54) 92.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #537   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files          17       17           
  Lines         468      468           
=======================================
  Hits          433      433           
  Misses         35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the suggestion for resolving the deprecation warning. If you know of other solutions please share. We'll remove the upper bound limit on dependencies as part of a separate change so this shouldn't be needed in the future.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to rebase and resolve conflicts. I merged #539 to make future maintenance easier.

Please update the Dependabot config with an item for the new rails_70 directory.

@tomascco tomascco force-pushed the chore/support-rails-71 branch from 60a19e0 to 22cac0a Compare October 6, 2023 23:25
@tomascco tomascco force-pushed the chore/support-rails-71 branch from 22cac0a to 708df54 Compare October 6, 2023 23:26
@javierjulio javierjulio changed the title Support Rails 7.1 Add ActiveSupport 7.1 as default setup Oct 7, 2023
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@javierjulio javierjulio merged commit 7aee5a8 into activeadmin:master Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants