Autofix save RuboCop performance offenses

- Performance/BlockGivenWithExplicitBlock - Performance/StringReplacement
activeadmin · Oct 24, 2023 · d55a7f7 · d55a7f7
1 parent 2b6b10e
commit d55a7f7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/arbre/context.rb b/lib/arbre/context.rb
@@ -44,7 +44,7 @@ def initialize(assigns = {}, helpers = nil, &block)
       @_current_arbre_element_buffer = [self]
 
       super(self)
-      instance_eval(&block) if block_given?
+      instance_eval(&block) if block
     end
 
     def arbre_context

diff --git a/lib/arbre/element/builder_methods.rb b/lib/arbre/element/builder_methods.rb
@@ -25,11 +25,11 @@ def build_tag(klass, *args, &block)
         tag.parent = current_arbre_element
 
         with_current_arbre_element tag do
-          if block_given? && block.arity > 0
+          if block && block.arity > 0
             tag.build(*args, &block)
           else
             tag.build(*args)
-            append_return_block(yield) if block_given?
+            append_return_block(yield) if block
           end
         end
 

diff --git a/lib/arbre/html/tag.rb b/lib/arbre/html/tag.rb
@@ -165,7 +165,7 @@ def dom_class_name_for(record)
         if record.class.respond_to?(:model_name)
           record.class.model_name.singular
         else
-          record.class.name.underscore.gsub("/", "_")
+          record.class.name.underscore.tr("/", "_")
         end
       end