Added OIDC client functionality in core package #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thboop
reviewed
Aug 19, 2021
packages/core/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@actions/core", | |||
| "version": "1.5.0", | |||
| "version": "1.5.1", | |||
There was a problem hiding this comment.
Lets go to 1.6.0.
Please also update the https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md file with this change under the version 1.6.0
|
Excited for this PR to land 🚀 . Left some minor comments on process, @luketomlinson is going to review the contents of the pr. |
luketomlinson
approved these changes
Aug 19, 2021
There was a problem hiding this comment.
A few minor things, but no show-stoppers. Good work @souravchanduka!
|
@souravchanduka, @TingluoHuang is going to coordinate when this should get merged/released. |
|
I am going to merge this PR to a feature branch, and create follow up PR to react to the latest update around OIDC on the service side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get the temporary credentials for accessing cloud resources, we need to get the ID Token from the action service. This ID Token will be used by login actions of different cloud providers. Since the code to fetch the ID Token will be same for all the login actions, we can use this functionality. All the login actions would import this package and get the ID token for further use.