Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add File Commands #571

Merged
merged 6 commits into from
Sep 23, 2020
Merged

Add File Commands #571

merged 6 commits into from
Sep 23, 2020

Conversation

thboop
Copy link
Collaborator

@thboop thboop commented Sep 11, 2020

No description provided.

docs/commands.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ericsciple ericsciple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, discussed offline

issueCommand('set-env', {name}, convertedVal)

const filePath = process.env['GITHUB_ENV'] || ''
if (filePath && filePath.length > 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: truthy check is sufficient (ensures length > 0)

docs/commands.md Outdated Show resolved Hide resolved
docs/commands.md Outdated Show resolved Hide resolved
docs/commands.md Outdated Show resolved Hide resolved
@thboop thboop merged commit 0759cdc into main Sep 23, 2020
@thboop thboop deleted the thboop/AddFileCommands branch September 23, 2020 15:19
tjamet added a commit to actions-go/toolkit that referenced this pull request Nov 2, 2020
tjamet added a commit to actions-go/toolkit that referenced this pull request Nov 2, 2020
* Add SetFailedf and IsDebug helpers

SetFailedf prevents from having to use Sprintf in caller methods

* Backport new ExportVariable and SetPath

Backport implementation from actions/toolkit#571
export function toCommandValue(input: any): string {
if (input === null || input === undefined) {
return ''
} else if (typeof input === 'string' || input instanceof String) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@akkim31 akkim31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run formet

Copy link

@Hbutlercapone Hbutlercapone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added File Commands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants