multiple glob patterns #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
commented
Jan 6, 2020
ericsciple
commented
Jan 6, 2020
| import {MatchKind} from './internal-match-kind' | ||
| import {Pattern} from './internal-pattern' | ||
|
|
||
| const IS_WINDOWS = process.platform === 'win32' | ||
|
|
||
| /** |
ericsciple
commented
Jan 6, 2020
ericsciple
commented
Jan 6, 2020
| /** | ||
| * Used to match files and directories | ||
| */ | ||
| export interface Globber { |
There was a problem hiding this comment.
the new interface for getting search paths and globbing for files
ericsciple
commented
Jan 6, 2020
ericsciple
commented
Jan 6, 2020
ericsciple
commented
Jan 6, 2020
ericsciple
commented
Jan 6, 2020
|
|
||
| /** | ||
| * Returns files and directories matching the specified glob pattern. | ||
| * Constructs a globber |
There was a problem hiding this comment.
now this file is only used to export the interfaces (Globber, GlobOptions) and instantiate a globber (create)
everything else moved into internal-globber.ts
Binh0103
approved these changes
Jan 8, 2020
ericsciple
commented
Jan 8, 2020
| /** | ||
| * Constructs a DefaultGlobber | ||
| */ | ||
| static async create( |
There was a problem hiding this comment.
this create function is new, everything else in this file basically moved into this class (was in glob.ts)
TingluoHuang
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables multiple patterns