-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix print outputs step in existing workflows #859
Conversation
@luketomlinson @rentziass @flaxel @JoannaaKL could you take a look at this PR? 🙏 |
@luketomlinson @rentziass @JoannaaKL friendly ping 😄 I think I need one more approval to merge |
@luketomlinson @rentziass @JoannaaKL friendly ping. |
1 similar comment
@luketomlinson @rentziass @JoannaaKL friendly ping. |
@luketomlinson @rentziass @JoannaaKL @pje @marko-zivic-93 @e-korolevskii friendly ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you @e-korolevskii! it seems I don't have the required permissions to merge the PR, who could do it? cc @luketomlinson @rentziass @JoannaaKL @pje @marko-zivic-93 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for fixing! :)
…9287) * security: `set-output` cmd deprecated. Use `$GITHUB_OUTPUT` env file To avoid untrusted logged data to use `save-state` and `set-output` workflow commands without the intention of the workflow author we have introduced a new set of environment files to manage state and output. Starting 1st June 2023 workflows using `save-state` or `set-output` commands via stdout will fail with an error. https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ * chore: apply fix found at actions/stale#859 * test: fixing report escapes * test: fixing report escapes * test: fixing report escapes * test: fixing report escapes * test: fixing report escapes
Changes
Print outputs
which is causing the current workflows failing.Context
The current workflows are failing in the repo, they are stuck in the
Print outputs
step. After debugging them using act, I realized the outputs were printed wrong, repeating all the properties from each array element over and over again, such as:The error is more notorious now and causes the workflows failing due to we have more staled/closed issues and pull requests in the repo.
Using the toJSON expression to get a pretty-print JSON representation for each output fixes the problem.