Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download from node-versions and fallback to node dist #147

Merged
merged 32 commits into from
May 19, 2020
Merged
Show file tree
Hide file tree
Changes from 31 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
ecf0ce6
wip
bryanmacfarlane Apr 24, 2020
8885b71
updated tests
bryanmacfarlane May 2, 2020
889def3
update ts-jest
bryanmacfarlane May 2, 2020
ec6092f
dbg
bryanmacfarlane May 2, 2020
1c2f59f
format
bryanmacfarlane May 2, 2020
22c0aea
cya snapshot
bryanmacfarlane May 2, 2020
8a1d983
format
bryanmacfarlane May 2, 2020
efab84a
dist
bryanmacfarlane May 2, 2020
ed3a918
Merge pull request #153 from actions/start-v2
bryanmacfarlane May 2, 2020
2bdb2ab
strip 1 on fallback extract
bryanmacfarlane May 2, 2020
501fd29
Merge branch 'master' into node-versions
bryanmacfarlane May 2, 2020
e3ad114
dist
bryanmacfarlane May 2, 2020
2fb08c4
update workflows
bryanmacfarlane May 3, 2020
5e5ef8f
update
bryanmacfarlane May 3, 2020
1b2d431
win change
bryanmacfarlane May 3, 2020
c8617ac
win change
bryanmacfarlane May 3, 2020
42746a4
dbg
bryanmacfarlane May 3, 2020
a414557
dbg
bryanmacfarlane May 3, 2020
f7c5caf
dbg
bryanmacfarlane May 3, 2020
dd6f5ab
only node binary issue
bryanmacfarlane May 3, 2020
11f9205
no proxy issue
bryanmacfarlane May 3, 2020
beb2155
testing 7z alt
bryanmacfarlane May 3, 2020
9fcef3f
testing 7z alt
bryanmacfarlane May 3, 2020
6a1b66a
dbg
bryanmacfarlane May 3, 2020
8e22109
dbg
bryanmacfarlane May 3, 2020
5e7b076
dbg
bryanmacfarlane May 3, 2020
a80a170
no proxy fix
bryanmacfarlane May 3, 2020
a875da2
output info
bryanmacfarlane May 3, 2020
0a9e8b1
output info
bryanmacfarlane May 3, 2020
2a0fbec
output info
bryanmacfarlane May 3, 2020
2ae9264
back to master
bryanmacfarlane May 4, 2020
e73ffbc
support ghes (#157)
ericsciple May 18, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: build-test
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I separated these into separate workflows so I can show badges for build-test, versions and proxy status on the readme. In general I like the separation.


on:
pull_request:
paths-ignore:
- '**.md'
push:
branches:
- master
- releases/*
paths-ignore:
- '**.md'

jobs:
build:
runs-on: ${{ matrix.operating-system }}
strategy:
matrix:
operating-system: [ubuntu-latest, windows-latest]
steps:
- uses: actions/checkout@v2
- name: Setup node 12
uses: actions/setup-node@v1
with:
node-version: 12.x
- run: npm ci
- run: npm run build
- run: npm run format-check
- run: npm test
- name: Verify no unstaged changes
if: runner.os != 'windows'
run: __tests__/verify-no-unstaged-changes.sh
56 changes: 56 additions & 0 deletions .github/workflows/proxy.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
name: proxy

on:
pull_request:
paths-ignore:
- '**.md'
push:
branches:
- master
- releases/*
paths-ignore:
- '**.md'

jobs:
test-proxy:
runs-on: ubuntu-latest
strategy:
fail-fast: false
container:
image: ubuntu:latest
options: --dns 127.0.0.1
services:
squid-proxy:
image: datadog/squid:latest
ports:
- 3128:3128
env:
https_proxy: http://squid-proxy:3128
steps:
- uses: actions/checkout@v2
- name: Clear tool cache
run: rm -rf $RUNNER_TOOL_CACHE/*
- name: Setup node 10
uses: ./
with:
node-version: 10.x
- name: Verify node and npm
run: __tests__/verify-node.sh 10

test-bypass-proxy:
runs-on: ubuntu-latest
strategy:
fail-fast: false
env:
https_proxy: http://no-such-proxy:3128
no_proxy: api.github.com,github.com,nodejs.org,registry.npmjs.org,*.s3.amazonaws.com,s3.amazonaws.com
steps:
- uses: actions/checkout@v2
- name: Clear tool cache
run: rm -rf $RUNNER_TOOL_CACHE/*
- name: Setup node 11
uses: ./
with:
node-version: 11
- name: Verify node and npm
run: __tests__/verify-node.sh 11
47 changes: 47 additions & 0 deletions .github/workflows/versions.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
name: versions

on:
pull_request:
paths-ignore:
- '**.md'
push:
branches:
- master
- releases/*
paths-ignore:
- '**.md'

jobs:
versions:
runs-on: ${{ matrix.operating-system }}
strategy:
fail-fast: false
matrix:
operating-system: [ubuntu-latest, windows-latest]
defaults:
run:
shell: bash
steps:
- uses: actions/checkout@v2
# test version that falls through to node dist
- name: Setup node 11 from dist
uses: ./
with:
node-version: 11
- name: Verify node and npm
run: __tests__/verify-node.sh 11
# test old versions which didn't have npm and layout different
- name: Setup node 0.12.18 from dist
uses: ./
with:
node-version: 0.12.18
- name: Verify node
shell: bash
run: __tests__/verify-node.sh 0.12.18 SKIP_NPM
# test version from node manifest
- name: Setup node 12.16.2 from manifest
uses: ./
with:
node-version: 12.16.2
- name: Verify node and npm
run: __tests__/verify-node.sh 12
100 changes: 0 additions & 100 deletions .github/workflows/workflow.yml

This file was deleted.

3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ node_modules/
lib/
__tests__/runner/*

validate/temp
validate/node
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a bash script to automate interactively validating without queuing a full run


# Rest of the file pulled from https://github.com/github/gitignore/blob/master/Node.gitignore
# Logs
logs
Expand Down
21 changes: 21 additions & 0 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"name": "Debug Jest Tests on Nix",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to step through jest tests with this. It works on mac / linux and I saw mention of different configs for windows but I didn't do that yet or validate so I called Nix.

"type": "node",
"request": "launch",
"runtimeArgs": [
"--inspect-brk",
"${workspaceRoot}/node_modules/.bin/jest",
"--runInBand"
],
"console": "integratedTerminal",
"internalConsoleOptions": "neverOpen",
"port": 9229
}
]
}
31 changes: 0 additions & 31 deletions __tests__/__snapshots__/authutil.test.ts.snap

This file was deleted.

Loading