Set output cache-hit to indicate if cache was hit
#275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @schuenadel. Thank you for your pull request. Could you please add check that matchedKey and primaryKey are equal, because for now the cache can hit for the restore key. |
Thanks, that makes sense. I misunderstood the return value of |
dmitry-shibanov
approved these changes
Jan 14, 2022
vsafonkin
approved these changes
Jan 17, 2022
|
@dmitry-shibanov Is there anything else needed to get this merged? Asking because I don't have the rights to merge. |
Closed
|
Hello @schuenadel. Sorry for the late response. Could you please sync with the main branch ? |
👍 Just did that |
ansraliant
added a commit
to ansraliant/setup-java
that referenced
this pull request
Aug 23, 2022
Cache hit was being used as stated in this pr actions#275. However, it was not included in the outputs of the action. It did not cause any mayor issues, but if you were to lint the workflows, then an output not defined error would pop up. This Commit just adds the output to the list. Nothing more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add the
cache-hitoutput to be able to execute later steps depending on if the cache was hit like it is possible with actions/cache. Like described here: https://github.com/actions/cache/tree/main#Skipping-steps-based-on-cache-hitRelated issue:
NoneEdit: Later this issue came up, which is addressed here: #306
Check list: