Fix macos ghcup and cabal flags (#4) #22
Conversation
* fix short-circuit logic for ghcup based installs of ghc * fix unrecognized user-config option for cabal v2.0 * update dependencies
|
@tclem looks like there have been a few things that needed fixing, but overall it seems the re-write has been quite stable :) When you have time, can you look this over? |
| if (installedPath) { | ||
| // Make sure that the correct ghc is used, even if ghcup has set a | ||
| // default prior to this action being ran. | ||
| if (tool === 'ghc' && installedPath === ghcupPath) |
There was a problem hiding this comment.
Nice. Is it just on macOS that a default is set with ghcup?
There was a problem hiding this comment.
I suspect it's just macOS currently, but this problem would also show up on any system where ghcup set was called. Wouldn't be terribly common, but I could envision a pipeline where someone used setup-haskell twice rather than a matrix? Either way, it's best to be robust and fix the actual underlying issue I think :)
| const bin = await tc.downloadTool( | ||
| `https://downloads.haskell.org/~ghcup/${v}/x86_64-${ | ||
| `https://downloads.haskell.org/ghcup/${v}/x86_64-${ |
There was a problem hiding this comment.
What's the difference with the ~ here?
There was a problem hiding this comment.
~ is the underlying url, I believe. I didn't know both worked until I saw that ghcup's documentation had started to use the new URL without the ~ in it, so I switched as well. They're identical in what they point to.
|
Moved the v1 tag forward as well. |
closes #21
closes #20
closes #18