-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GOBIN to PATH regardless of whether a version spec is specified #89
Conversation
I couldn't see where the tests were when I first made the change, but I see now they are in the |
I've added tests that pass with the change and fail without it. |
@bryanmacfarlane 👋 Looking for 👀 on this PR. Could this be accepted? |
ping @joshmgross |
ping @bryanmacfarlane |
ping @dmitry-shibanov ; any chance you could rescue this? |
Hello @jayvdb. Sorry for the late response. I'm not expert in the GO. Can it bring breaking changes ? |
No it cant bring breaking changes. |
Thank you for your response @jayvdb. I think in this case we can recreate this pull request and take a look at it. |
I'm running into this, any update? Ping @dmitry-shibanov since you mentioned recreating this PR. |
What
Add GOBIN to PATH regardless of whether a version spec is specified.
Why
The setup-go action adds the GOBIN to the PATH, but only if a version spec for Go is provided in the workflow configuration. When a version spec is provided the action ensures that version is installed, and then also that the GOBIN path is included in the PATH. The code that includes the GOBIN in the PATH has no dependency on the logic to install a specific version of Go and I can't see a reason why it can't run regardless. When it doesn't run, binaries that are installed in GOBIN by
go get
are not found by following steps in a workflow.Fix #49