Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GOBIN to PATH regardless of whether a version spec is specified #89

Closed
wants to merge 4 commits into from
Closed

Add GOBIN to PATH regardless of whether a version spec is specified #89

wants to merge 4 commits into from

Conversation

leighmcculloch
Copy link

What

Add GOBIN to PATH regardless of whether a version spec is specified.

Why

The setup-go action adds the GOBIN to the PATH, but only if a version spec for Go is provided in the workflow configuration. When a version spec is provided the action ensures that version is installed, and then also that the GOBIN path is included in the PATH. The code that includes the GOBIN in the PATH has no dependency on the logic to install a specific version of Go and I can't see a reason why it can't run regardless. When it doesn't run, binaries that are installed in GOBIN by go get are not found by following steps in a workflow.

Fix #49

@leighmcculloch
Copy link
Author

leighmcculloch commented Dec 4, 2020

I couldn't see where the tests were when I first made the change, but I see now they are in the __tests__ directory. I'll circle back on this soon to add a test that passes with the change and fails without it.

@leighmcculloch
Copy link
Author

I've added tests that pass with the change and fail without it.

@leighmcculloch
Copy link
Author

@bryanmacfarlane 👋 Looking for 👀 on this PR. Could this be accepted?

@jayvdb
Copy link

jayvdb commented Jun 24, 2021

ping @joshmgross

@jayvdb
Copy link

jayvdb commented Aug 9, 2021

ping @bryanmacfarlane

@leighmcculloch leighmcculloch deleted the issue49 branch May 15, 2022 03:10
@jayvdb
Copy link

jayvdb commented May 15, 2022

ping @dmitry-shibanov ; any chance you could rescue this?

@dmitry-shibanov
Copy link
Contributor

Hello @jayvdb. Sorry for the late response. I'm not expert in the GO. Can it bring breaking changes ?

@jayvdb
Copy link

jayvdb commented May 23, 2022

No it cant bring breaking changes.

@dmitry-shibanov
Copy link
Contributor

Thank you for your response @jayvdb. I think in this case we can recreate this pull request and take a look at it.

@walles
Copy link

walles commented Dec 19, 2022

I'm running into this, any update?

Ping @dmitry-shibanov since you mentioned recreating this PR.

walles added a commit to walles/moar that referenced this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: add GOBIN to PATH even if a version isn't installed
4 participants