Revise isGhes logic
#556
Merged
Revise isGhes logic
#556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyt
approved these changes
Oct 18, 2024
gowridurgad
approved these changes
Oct 21, 2024
aparnajyothi-y
approved these changes
Oct 21, 2024
|
Hello @jww3, Could you please run the npm ci && npm run format && npm run build command to resolve Basic Validation build failures. |
It looks like the checked-in installation scripts are out-of-date. (These are unrelated to my change.) Notice that this other no-op PR ends up having the same CI/CD failures. |
HarithaVattikuti
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I'm fixing the logic within helper method
isGhesto ensure that it doesn't misrecognize GitHub Enterprise Cloud instances as GHES instances.Related issue:
https://github.com/newsroom/press-releases/data-residency-in-the-eu
Check list: