-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make timeout for hashFiles()
configureable
#1844
base: main
Are you sure you want to change the base?
Conversation
- Removed checking if paramter starting with '--' is the first parameter
Not entirely sure, is there anything I need to do so the PR is reviewed, am I missing a step? @TingluoHuang sorry if I tag you directly, maybe you can advise? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo.
This Pr is really needed for us large gamedev project users, any update on this ? |
Agree! (realizing I'm replying to a comment from 10 mo ago) |
Any updates for this issue or this should be closed? We caught the same error and suspect our runner fails because we have large files to hash and it could go over 120s in many cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems good
This merge should solve issue #1840
Hey guys, we're running into the same issue with the 120 second |
So what's the status on this? |
Bump? |
Running into this as well, it's weird, with 4 vCPU it runs fine, with 32 vCPU (on a very large runner for extra heavy tasks) it fails, if I run the same task on a smaller runner, it succeeds, but the whole workflow takes much longer. |
also would like to have this |
As reported here #1840, in scenarios where a lot of files need to be hashed to build up a cache, the process running
hashFiles()
may run into the fixed 120 second timeout and be cancelled prematurely.This pull request introduces a new parameter
--timeout=
that is meant to be passed the same way as the already existing optional parameter--follow-symbolic-links
.Example configuration for actions/cache:
Points of discussion:
hashFiles()
command itself, but rather to how it is run. If you see an alternative way of injecting such a parameter, please let me know.firstParameter
and the connected logic. Instead, the logic now looks for if a parameter name starts with--
and tries to match one of the two expected parameters. Please let me know if you strongly feel the logic that these parameters need to be first is needed, I will then put something in.