Use job execution context instead of step for adding summary attachments #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfleidi
approved these changes
Feb 8, 2022
TingluoHuang
approved these changes
Feb 8, 2022
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Aug 8, 2022
…nts (actions#1667) * use job exec context to queue/attach summaries * step summary tests: use job ctx and verify against server queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1642, the execution context used for
QueueAttachFilewas originally the Job context but was incorrectly refactored to use the Step context. This is incorrect, since the API will use the job context as per: https://github.com/github/actions-dotnet/pull/10957Also, attaching to the step context is not supported according to:
runner/src/Runner.Worker/DiagnosticLogManager.cs
Line 106 in be96323