[Ubuntu] Allow image_sku to be passed in as variable #6756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commenter does not have sufficient privileges for PR 6756 in repo actions/runner-images |
|
This is my first contribution to this repo. Is there anything else that I need to complete to obtain a review of this PR? @mikhailkoliada @maxim-lobanov @al-cheb @Alexey-Ayupov |
ifutant
changed the title
|
Hello! We do not plan using any alternative sku, so it makes little sense in general for us to use the variable here. So, we would not like to change it anyhow. |
|
Why not introduce additional flexibility especially since Gen2 virtual machines are more modern? Just because your team doesn't plan to utilize an alternate SKU at the moment, that may not always be the case. What is the harm in making a small modification that facilities SKU parametrization while also maintaining existing functionality without impacting current users? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request seeks to modify the latest Ubuntu 22.04 Packer template to allow an override of the hard-coded image_sku. This change introduces a new variable, and contains the hard-coded value as its default.
The reason I desire to perform this override is to allow the deployment of a Generation 2 VM while consuming the packer template. I only targeted the images/linux/ubuntu2204.pkr.hcl file, because I didn't want to introduce a new variable dependency. I anticipate that this change will not impact current users of this packer template.
Additional Information:
Gen 2 VM Details
Check list