Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install clang-format #447

Merged
merged 2 commits into from
Mar 9, 2020
Merged

Install clang-format #447

merged 2 commits into from
Mar 9, 2020

Conversation

NilsIrl
Copy link
Contributor

@NilsIrl NilsIrl commented Feb 22, 2020

@miketimofeev
Copy link
Contributor

/azp run ubuntu1604, ubuntu1804

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 447 in repo actions/virtual-environments

@maxim-lobanov
Copy link
Contributor

/azp run ubuntu1604, ubuntu1804

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@alepauly
Copy link
Contributor

alepauly commented Mar 3, 2020

/azp ubuntu1604

@azure-pipelines
Copy link

Command 'ubuntu1604' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

alepauly
alepauly approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@alepauly alepauly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @NilsIrl! I'll await for success of the verification build I just kicked off and merge.

@maxim-lobanov
Copy link
Contributor

/azp run ubuntu1604

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@EFanZh
Copy link

EFanZh commented Mar 6, 2020

How about making clang-format-9 as the default clang-format using update-alternatives? Since clang-9 and clang++-9 has already been set as default.

@NilsIrl
Copy link
Contributor Author

NilsIrl commented Mar 6, 2020

How about making clang-format-9 as the default clang-format using update-alternatives

Great idea! Pushed a commit for this.

@NilsIrl NilsIrl requested a review from alepauly March 7, 2020 11:32
@maxim-lobanov
Copy link
Contributor

/azp run ubuntu1604, ubuntu1804

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@miketimofeev
Copy link
Contributor

@NilsIrl I'm afraid you've missed the name for the clang-format
update-alternatives: --install needs <link> <name> <path> <priority>

@NilsIrl
Copy link
Contributor Author

NilsIrl commented Mar 7, 2020

I'm afraid you've missed the name for the clang-format

Thank you, fixed it.

@maxim-lobanov
Copy link
Contributor

/azp run ubuntu1604, ubuntu1804

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@miketimofeev miketimofeev self-requested a review March 9, 2020 20:19
@alepauly alepauly merged commit 106b634 into actions:master Mar 9, 2020
@NilsIrl NilsIrl deleted the clang-format branch March 9, 2020 22:13
NilsIrl added a commit to NilsIrl/ccextractor that referenced this pull request Mar 20, 2020
@NilsIrl
Remove installation of clang
1db63e1 
This is possible thanks to
actions/runner-images#447
NilsIrl added a commit to NilsIrl/ccextractor that referenced this pull request Mar 20, 2020
@NilsIrl
Remove installation of clang
a461372 
This is possible thanks to
actions/runner-images#447
NilsIrl added a commit to NilsIrl/ccextractor that referenced this pull request Mar 20, 2020
@NilsIrl
Remove installation of clang
79f3f4b 
This is possible thanks to
actions/runner-images#447
NilsIrl added a commit to NilsIrl/ccextractor that referenced this pull request Mar 20, 2020
@NilsIrl
Remove installation of clang
bb69b69 
This is possible thanks to
actions/runner-images#447
@NilsIrl NilsIrl mentioned this pull request Mar 20, 2020
Merged
canihavesomecoffee pushed a commit to CCExtractor/ccextractor that referenced this pull request Mar 20, 2020
@NilsIrl
Remove installation of clang (#1244)
b974a7e 
This is possible thanks to
actions/runner-images#447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketimofeev miketimofeev miketimofeev approved these changes

@al-cheb al-cheb Awaiting requested review from al-cheb

@AlenaSviridenko AlenaSviridenko Awaiting requested review from AlenaSviridenko

@maxim-lobanov maxim-lobanov Awaiting requested review from maxim-lobanov

@vmapetr vmapetr Awaiting requested review from vmapetr

@alepauly alepauly Awaiting requested review from alepauly

Assignees
No one assigned
Labels
Area: C/C++ enhancement New feature or request OS: Ubuntu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NilsIrl @miketimofeev @maxim-lobanov @alepauly @EFanZh