-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to use hkps over port 443 instead of 11371 to resolve issue https://github.com/actions/runner-images/discussions/9963 #10007
Open
lukasbbuehler
wants to merge
4
commits into
actions:main
Choose a base branch
from
lukasbbuehler:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change to use port 80 instead of 11371
Changed to hkps and port 443 for added security
lukasbbuehler
changed the title
Change to use port 80 instead of 11371 to resolve issue https://github.com/actions/runner-images/discussions/9963
Change to use hkps over port 443 instead of 11371 to resolve issue https://github.com/actions/runner-images/discussions/9963
Jun 10, 2024
Could someone approve this? We're facing the same issue. |
erik-bershel
previously approved these changes
Sep 1, 2024
|
Kichura
approved these changes
Dec 7, 2024
dav3yblaz3
approved these changes
Dec 18, 2024
Just added the missing line for the signatures to resolve merge conflicts |
dav3yblaz3
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for test thanks team
erik-bershel
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: Changed in the second commit to hkps over port 443 to improve security. Works also like a charm.
Change to use port 80 instead of 11371 to fix this issue: #9963
We tested the commands manually on our machines to verify if the script would work.
Description
New tool, Bug fixing, or Improvement?
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.
For new tools, please provide total size and installation time.
Related issue:
Check list