Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Git (for Windows) to v2.47.0.windows.2 #10843

Closed
3 of 16 tasks
vorporeal opened this issue Oct 22, 2024 · 19 comments
Closed
3 of 16 tasks

Update Git (for Windows) to v2.47.0.windows.2 #10843

vorporeal opened this issue Oct 22, 2024 · 19 comments

Comments

@vorporeal
Copy link

Tool name

Git

Tool license

GPL v2

Add or update?

  • Add
  • Update

Desired version

v2.47.0.windows.2

Approximate size

No response

Brief description of tool

No response

URL for tool's homepage

No response

Provide a basic test case to validate the tool's functionality.

No response

Platforms where you need the tool

  • Azure DevOps
  • GitHub Actions

Runner images where you need the tool

  • Ubuntu 20.04
  • Ubuntu 22.04
  • Ubuntu 24.04
  • macOS 12
  • macOS 13
  • macOS 13 Arm64
  • macOS 14
  • macOS 14 Arm64
  • macOS 15
  • macOS 15 Arm64
  • Windows Server 2019
  • Windows Server 2022

Can this tool be installed during the build?

No response

Tool installation time in runtime

No response

Are you willing to submit a PR?

No response

@vorporeal
Copy link
Author

Git v2.47.0.windows.1 has a bug that causes problems fetching repositories via SSH: git-for-windows/git#5199

v2.47.0.windows.1 was rolled out in the 20241015.1.0 Windows Server image release.

v2.47.0.windows.2 was released today with a fix for the issue, and should be included in the Windows Server runner images ASAP to mitigate user impact (it broke one of our workflows, which could no longer reliably fetch a private GitHub repository over SSH).

@hemanthmanga
Copy link
Contributor

Hi @vorporeal, Thank you for bringing this issue to our attention. We are looking into this issue and will update you on this issue after investigating.

vszakats added a commit to curl/curl that referenced this issue Oct 23, 2024
Fix the significant perf regression for vcpkg jobs by switching to the
MSYS2 shell environment from Git for Windows. This env is already used
for old-mingw-w64 job that remained unaffected by this issue.

The issue began with the windows-runner update 20241015.1.0. It bumped
Git for Windows from Git 2.46.2.windows.1 to Git 2.47.0.windows.1. GfW
bumped its MSYS2 components, including `msys-2.0.dll`. That's Cygwin
code, which may have contributed to this. Pipes were involved and
`runtests.pl` relies on pipes heavily in parallel mode. (The issue was
not seen with parallel tests disabled, in retrospect.)

This is useful as a permanent solution too. It drop GfW as a dependency
and makes Windows jobs use one less shell/env flavour.

Long term it might help to use native Windows Perl to avoid the MSYS
layer completely, if there is a way to make that work.

Assortment of possibly related links:
https://cygwin.com/pipermail/cygwin/2024-August/256398.html
cygwin/cygwin@f78009c
cygwin/cygwin@7f3c225

actions/runner-images#10843
git-for-windows/git#5199
git-for-windows/msys2-runtime#75
git-for-windows/msys2-runtime@7913a41
git-for-windows/msys2-runtime@555afcb
cygwin/cygwin@1c5f4dc

Follow-up to c33174d #15364
Follow-up to 1e03059 #15356

Closes #15380
rotu added a commit to CeruleanSonar/SonarView that referenced this issue Oct 24, 2024
workaround for bug in GHA which causes hg to hang on ssh remotes.
actions/runner-images#10843
git-for-windows/git#5199
@UrsDeSwardt
Copy link

Any progress on this? 🙂

@pulkitsharma07
Copy link

pulkitsharma07 commented Oct 25, 2024

Issue with git getting stuck in windows got resolved after updating git to version 2.47.0.windows.2

Add this step in the workflow (taken from CeruleanSonar/SonarView#10) before invoking any git command:

    - name: Bump git-for-windows
      if: runner.os == 'Windows'
      shell: pwsh
      run: |
        Invoke-WebRequest -Uri "https://github.com/git-for-windows/git/releases/download/v2.47.0.windows.2/Git-2.47.0.2-64-bit.exe" -OutFile "${{runner.temp}}/git-for-windows.exe"
        Start-Process -Filepath "${{runner.temp}}/git-for-windows.exe" -ArgumentList  @("/VERYSILENT","/NORESTART","/NOCANCEL","/SP-","/CLOSEAPPLICATIONS","/RESTARTAPPLICATIONS","/o:PathOption=CmdTools","/o:BashTerminalOption=ConHost","/o:EnableSymlinks=Enabled","/COMPONENTS=gitlfs") -NoNewWindow -Wait

@dwhite91307
Copy link

Please fix the Windows runners promptly. Our company was also hit by this issue.

@vaibhavagrawal2912
Copy link

vaibhavagrawal2912 commented Oct 26, 2024

This has become a blocker for us. Can this be prioritised and deployed sooner?
The above workaround consumes usage against the plan, which in my opinion don’t think teams/individuals have to bourne on private repos.

@rotu
Copy link

rotu commented Oct 26, 2024

FWIW, I think neither the above workaround nor faster turnaround on issues like this really address the problem.

It would be nice to be able to rollback the runner to a working image1 and/or to have Windows container support2.

Footnotes

  1. https://github.com/actions/runner-images/discussions/7521

  2. https://github.com/actions/runner/issues/904

@lakshminarayana02
Copy link

Hi
We are looking into this problem and will make sure that the latest Git version will be included on subsequent image releases. We appreciate your patience with us.

@berleant
Copy link

My org is also affected by this issue, and the workaround posted above does not work (times out). Do you have a timeline for getting this fixed?

@hlevring
Copy link

hlevring commented Nov 1, 2024

Yeah, we are also one of the unlucky once. We have been scratching our heads for a couple of days spending a ton of man hours before we finally contacted github support who pointed to this thread

@flavienbwk
Copy link

Yeah, we are also one of the unlucky once. We have been scratching our heads for a couple of days spending a ton of man hours before we finally contacted github support who pointed to this thread

Same, 20h lost for that. GitHub not checking its runners to work correctly with git is unbelievable.

@lakshminarayana02
Copy link

Hi
We are working on this update should be added to the future runner images as soon as possible.

@vorporeal
Copy link
Author

For folks running into this issue, we've found the following step to be an easy and reliable way to get git-for-windows updated to the latest version:

  - name: Update to latest git-for-windows
    run: |
      Start-Process git -Wait -ArgumentList 'update-git-for-windows -y'

@berleant
Copy link

Hi We are working on this update should be added to the future runner images as soon as possible.

Can you give an estimated date for the fix?

@lakshminarayana02
Copy link

Hi @berleant
We understand that the most recent fix version has been released and is available, but in order to include it in our images, we must complete a strict process that includes numerous tests. Please be patient with us. and, certainly, we are working on it.

@rotu
Copy link

rotu commented Nov 21, 2024

We understand that the most recent fix version has been released and is available, but in order to include it in our images, we must complete a strict process that includes numerous tests. Please be patient with us. and, certainly, we are working on it.

@lakshminarayana02, Hopefully a slightly better process than the one that deployed v2.47.0.windows.1 into these images.

Any reason the image wasn't just rolled back to 20241006.1.0, which was before the breaking change? This seems like one of the main reasons actions/runner-images is under source control in the first place!

@lakshminarayana02
Copy link

Hi

We have been working on it and have done the testing, but for some reason, the version has been brought back to the previous version from the authorised source repository, from which we used to regularly download the latest version for our images.

Reference links are included.
https://github.com/git-for-windows/git/tree/v2.47.1.windows.1
https://github.com/git-for-windows/git/releases/tag/v2.47.1.windows.1

Once the new version is out, will update our images and we appreciate your patience and suggestions.

@ajungg
Copy link

ajungg commented Nov 27, 2024

Its there since Okt 22 https://github.com/git-for-windows/git/releases/tag/v2.47.0.windows.2

The faulty version was 2.47.0.windows.1 not 2.47.1.windows.1

@lakshminarayana02
Copy link

Hi @ajungg
yes, we are confirming you that v2.47.1.windows.1 . it will be available in next week release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests