Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branches to merge-group schema #12

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

lrotschy
Copy link
Contributor

@lrotschy lrotschy commented Apr 5, 2023

github/vscode-github-actions#40

Added branches to merge_group schema.

add-branch-to-merge-group-schema

@lrotschy lrotschy marked this pull request as ready for review April 5, 2023 16:29
@lrotschy lrotschy requested a review from a team as a code owner April 5, 2023 16:29
@lrotschy lrotschy merged commit 53f5a4c into main Apr 5, 2023
@lrotschy lrotschy deleted the lrotschy/add-branches-to-merge-group-schema branch April 5, 2023 17:33
@muzimuzhi
Copy link
Contributor

Just for the completeness, does merge_group trigger also support a branches-ignore filter?

Tests in muzimuzhi/hello-github-actions#9 show invalid filter won't fail a workflow run so the difference seems not observable by external users.

The blog introducing merge_group trigger contains a demo using branches filter, so branches is definitely supported. Since branches and branches-ignore are so closely related, I guess branches-ignore is supported as well.

@lrotschy
Copy link
Contributor Author

I will open a new issue for adding branches-ignore to the schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants