Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): add GHES workflow example #104

Merged
merged 5 commits into from
Feb 21, 2024
Merged

Conversation

mouismail
Copy link
Contributor

@mouismail mouismail commented Feb 19, 2024

This pull request includes a significant change to the README.md file. The change adds a new job to the GitHub Actions workflow, which is designed to create an example of how to use create-github-app-token action on GitHub Enterprise Server.

Resolves #98

@mouismail mouismail requested review from gr2m, parkerbxyz and a team as code owners February 19, 2024 16:47
@mouismail mouismail changed the title Add GHES example Improve README.md to add GHES example Feb 20, 2024
@mouismail mouismail changed the title Improve README.md to add GHES example Improve README.md to add GHES example Feb 20, 2024
Copy link
Contributor

@parkerbxyz parkerbxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mouismail! Just a couple of small suggested changes for your consideration.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@parkerbxyz parkerbxyz changed the title Improve README.md to add GHES example docs(README): add GHES workflow example Feb 20, 2024
mouismail and others added 2 commits February 21, 2024 02:21
Co-authored-by: Parker Brown <17183625+parkerbxyz@users.noreply.github.com>
Co-authored-by: Parker Brown <17183625+parkerbxyz@users.noreply.github.com>
@mouismail
Copy link
Contributor Author

Thanks, @mouismail! Just a couple of small suggested changes for your consideration.

Thanks @parkerbxyz I have committed your changes.

@SkakimSAP
Copy link

FYI, the feedback from a GHES User:

just fyi, the solution in the PR works perfectly for generating the app installation token from public to enterprise GH 🙂

@gr2m gr2m merged commit 1e02bd5 into actions:main Feb 21, 2024
2 checks passed
@create-app-token-action-releaser

🎉 This PR is included in version 1.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete example in README
4 participants