Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to actually invoke the desired method instead of replicating it #53

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

JamesMGreene
Copy link
Contributor

I noticed our tests for setPagesConfig weren't actually invoking setPagesConfig but rather replicating the contents of that method. Doesn't seem like we needed to do that, so I've closed that potential gap. 🤷🏻‍♂️

@JamesMGreene JamesMGreene requested a review from a team as a code owner January 31, 2023 14:14
@JamesMGreene JamesMGreene merged commit 1d79de2 into main Feb 1, 2023
@JamesMGreene JamesMGreene deleted the test-set-pages-config branch February 1, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants