Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url-helper.ts now leverages well-known environment variables. #1941

Merged
merged 11 commits into from
Oct 18, 2024
Merged

url-helper.ts now leverages well-known environment variables. #1941

merged 11 commits into from
Oct 18, 2024
+141 −23

Commits on Oct 11, 2024

  1. utl-helper.ts now leverages well-known environment variables.

    @jww3
    jww3 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e8e8219 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. second attempt

    @jww3
    jww3 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    df4b58c View commit details
    Browse the repository at this point in the history

  2. restore passing baseUrl where appropriate

    @jww3
    jww3 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    2f42443 View commit details
    Browse the repository at this point in the history

  3. ran npm run format

    @jww3
    jww3 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    7fcbcdc View commit details
    Browse the repository at this point in the history

  4. ran npm run build

    @jww3
    jww3 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    19060a1 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Apply suggestions from @easyt 

    Co-authored-by: Erez Testiler <easyt@github.com>
    @jww3 @easyt
    jww3 and easyt authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    813c3f2 View commit details
    Browse the repository at this point in the history

  2. updated unit tests

    @jww3
    jww3 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    041723a View commit details
    Browse the repository at this point in the history

  3. Responded to PR feedback.

    @jww3
    jww3 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    914445f View commit details
    Browse the repository at this point in the history

  4. ran npm run build

    @jww3
    jww3 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    7695871 View commit details
    Browse the repository at this point in the history

  5. Address hasContent readability

    @jww3
    jww3 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    7fd13ec View commit details
    Browse the repository at this point in the history

  6. Use concise WhitespaceMode names

    @jww3
    jww3 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    55f79d9 View commit details
    Browse the repository at this point in the history