Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make octokit follow proxy setting. #138

Closed
wants to merge 1 commit into from
Closed

make octokit follow proxy setting. #138

wants to merge 1 commit into from

Conversation

TingluoHuang
Copy link
Member

@TingluoHuang TingluoHuang commented Jan 16, 2020 •
edited
Loading

@TingluoHuang TingluoHuang force-pushed the users/tihuang/proxysupport branch 2 times, most recently from ffb1c56 to 85f1b34 Compare January 16, 2020 19:31
@ericsciple
Copy link
Contributor

ericsciple commented Jan 17, 2020 •
edited
Loading

i have a changes locally, for the toolkit (havent published the PR yet, waiting on new http-client to be published)

lets fix in the toolkit instead and then bump package.json to consume new toolkit

http-client pr is merged, pending publish

toolkit pr is here (i have a little bit more to finish tomorrow)

@ericsciple ericsciple closed this Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsciple ericsciple Awaiting requested review from ericsciple

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TingluoHuang @ericsciple