Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run git fetch with --quiet by default #894

Closed
Trass3r opened this issue Aug 18, 2022 · 2 comments · Fixed by #1067
Closed

Run git fetch with --quiet by default #894

Trass3r opened this issue Aug 18, 2022 · 2 comments · Fixed by #1067

Comments

@Trass3r
Copy link

Trass3r commented Aug 18, 2022

https://git-scm.com/docs/git-fetch#Documentation/git-fetch.txt--q

As has been noted before in the prematurely closed #489 and #18 the fetch progress does not add any value and just clutters the logs, esp. the raw logs.
The folding in the UI does not fix the issue for the raw logs.
And in general it's a waste of bandwidth and everything.
@gladiatr72
Copy link

The speed of the scroll makes it a race as to whether or not that segment can be closed before the control to close it is pushed from the display.

simonbaird added a commit to simonbaird/checkout that referenced this issue Jan 5, 2023
@simonbaird
Support fetching without the --progress option
fefb954 
Setting the `progress` option to false in the `with` section of the
workflow step will cause git fetch to not use the `--progress` option.

The motivation is to be able to suppress the many hundreds of lines
of noisy progress status output such as "remote: Counting objects:
85% (386/453)"

Should be sufficient to resolve actions#894 and its older friends, though
the solution is different to the one proposed there because it
doesn't use the --quiet flag.

IIUC git doesn't show the progress status by default since the
output is not a terminal, so that's why removing the --progress
option is all that's needed.
simonbaird added a commit to simonbaird/checkout that referenced this issue Jan 5, 2023
@simonbaird
Support fetching without the --progress option
daadf0a 
Setting the `progress` option to false in the `with` section of the
workflow step will cause git fetch to run without `--progress`.

The motivation is to be able to suppress the noisy progress status
output which adds many hundreds of "remote: Counting objects: 85%
(386/453)" and similar lines in the workflow log.

This should be sufficient to resolve actions#894 and its older friends,
though the solution is different to the one proposed there because
it doesn't use the --quiet flag. IIUC git doesn't show the progress
status by default since the output is not a terminal, so that's why
removing the --progress option is all that's needed.
simonbaird added a commit to simonbaird/checkout that referenced this issue Jan 5, 2023
@simonbaird
Support fetching without the --progress option
51e92ef 
Setting the `progress` option to false in the `with` section of the
workflow step will cause git fetch to run without `--progress`.

The motivation is to be able to suppress the noisy progress status
output which adds many hundreds of "remote: Counting objects: 85%
(386/453)" and similar lines in the workflow log.

This should be sufficient to resolve actions#894 and its older friends,
though the solution is different to the one proposed there because
it doesn't use the --quiet flag. IIUC git doesn't show the progress
status by default since the output is not a terminal, so that's why
removing the --progress option is all that's needed.
@simonbaird simonbaird mentioned this issue Jan 5, 2023
Merged
@simonbaird
Copy link
Contributor

FYI I don't think --quiet is really needed. All that's required to squelch the noisy log output is to remove the --progress option. See #1067 where I've created a patch that should do it.

simonbaird added a commit to simonbaird/checkout that referenced this issue Jan 5, 2023
@simonbaird
Support fetching without the --progress option
87596e0 
Setting the `progress` option to false in the `with` section of the
workflow step will cause git fetch to run without `--progress`.

The motivation is to be able to suppress the noisy progress status
output which adds many hundreds of "remote: Counting objects: 85%
(386/453)" and similar lines in the workflow log.

This should be sufficient to resolve actions#894 and its older friends,
though the solution is different to the one proposed there because
it doesn't use the --quiet flag. IIUC git doesn't show the progress
status by default since the output is not a terminal, so that's why
removing the --progress option is all that's needed.
simonbaird added a commit to simonbaird/checkout that referenced this issue May 4, 2023
@simonbaird
Support fetching without the --progress option
3327cce 
Setting the `progress` option to false in the `with` section of the
workflow step will cause git fetch to run without `--progress`.

The motivation is to be able to suppress the noisy progress status
output which adds many hundreds of "remote: Counting objects: 85%
(386/453)" and similar lines in the workflow log.

This should be sufficient to resolve actions#894 and its older friends,
though the solution is different to the one proposed there because
it doesn't use the --quiet flag. IIUC git doesn't show the progress
status by default since the output is not a terminal, so that's why
removing the --progress option is all that's needed.
simonbaird added a commit to simonbaird/checkout that referenced this issue Jul 25, 2023
@simonbaird
Support fetching without the --progress option
ce4272e 
Setting the `progress` option to false in the `with` section of the
workflow step will cause git fetch to run without `--progress`.

The motivation is to be able to suppress the noisy progress status
output which adds many hundreds of "remote: Counting objects: 85%
(386/453)" and similar lines in the workflow log.

This should be sufficient to resolve actions#894 and its older friends,
though the solution is different to the one proposed there because
it doesn't use the --quiet flag. IIUC git doesn't show the progress
status by default since the output is not a terminal, so that's why
removing the --progress option is all that's needed.

Adding the --quiet flag doesn't make a lot of difference once the
--progress flag is removed, and actually I think it would suppress
some other useful output that would be better to show.

Signed-off-by: Simon Baird <sbaird@redhat.com>
simonbaird added a commit to simonbaird/checkout that referenced this issue Jul 25, 2023
@simonbaird
Support fetching without the --progress option
d053b2f 
Setting the `progress` option to false in the `with` section of the
workflow step will cause git fetch to run without `--progress`.

The motivation is to be able to suppress the noisy progress status
output which adds many hundreds of "remote: Counting objects: 85%
(386/453)" and similar lines in the workflow log.

This should be sufficient to resolve actions#894 and its older friends,
though the solution is different to the one proposed there because
it doesn't use the --quiet flag. IIUC git doesn't show the progress
status by default since the output is not a terminal, so that's why
removing the --progress option is all that's needed.

Adding the --quiet flag doesn't make a lot of difference once the
--progress flag is removed, and actually I think it would suppress
some other useful output that would be better to show.

Signed-off-by: Simon Baird <sbaird@redhat.com>
simonbaird added a commit to simonbaird/checkout that referenced this issue Aug 30, 2023
@simonbaird
Support fetching without the --progress option
4d7e069 
Setting the `progress` option to false in the `with` section of the
workflow step will cause git fetch to run without `--progress`.

The motivation is to be able to suppress the noisy progress status
output which adds many hundreds of "remote: Counting objects: 85%
(386/453)" and similar lines in the workflow log.

This should be sufficient to resolve actions#894 and its older friends,
though the solution is different to the one proposed there because
it doesn't use the --quiet flag. IIUC git doesn't show the progress
status by default since the output is not a terminal, so that's why
removing the --progress option is all that's needed.

Adding the --quiet flag doesn't make a lot of difference once the
--progress flag is removed, and actually I think using --quiet would
suppress some other more useful output that would be better left
visible.

Signed-off-by: Simon Baird <sbaird@redhat.com>
vanZeben pushed a commit that referenced this issue Sep 1, 2023
@simonbaird
Support fetching without the --progress option (#1067)
8b5e8b7 
Setting the `show-progress` option to false in the `with` section of the
workflow step will cause git fetch to run without `--progress`.

The motivation is to be able to suppress the noisy progress status
output which adds many hundreds of "remote: Counting objects: 85%
(386/453)" and similar lines in the workflow log.

This should be sufficient to resolve #894 and its older friends,
though the solution is different to the one proposed there because
it doesn't use the --quiet flag. IIUC git doesn't show the progress
status by default since the output is not a terminal, so that's why
removing the --progress option is all that's needed.

Adding the --quiet flag doesn't make a lot of difference once the
--progress flag is removed, and actually I think using --quiet would
suppress some other more useful output that would be better left
visible.

Signed-off-by: Simon Baird <sbaird@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support fetching without the --progress option simonbaird/checkout
3 participants
@simonbaird @Trass3r @gladiatr72