Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint from 8.x to 9.x #418

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Update eslint from 8.x to 9.x #418

merged 1 commit into from
Dec 16, 2024

Conversation

bdehamer
Copy link
Collaborator

This change is primarily about updating eslint from 8.x to 9.x but also includes a number of related changes to the linter configuration.

  • Switch to the new eslint flat config format.
  • Remove integration between eslint and prettier (per guidance from the Prettier team).
  • Remove the @typescript-eslint/eslint-plugin and @typescript-eslint/parser plugins in favor of the new typescript-eslint package.
  • Remove the unused eslint-plugin-jsonc package.
  • Remove the eslint-plugin-github package. This package contains a lot of duplicate rules and prettier-related integration that we no longer want/need.

By removing the eslint-plugin-github package, the only rules we losing are those from the eslint-plugin-eslint-comments package (which is of minimal value) and the following GitHub-specific rules:

Signed-off-by: Brian DeHamer <bdehamer@github.com>
@bdehamer bdehamer requested a review from a team as a code owner December 13, 2024 21:03
@bdehamer bdehamer merged commit f4b7552 into main Dec 16, 2024
20 checks passed
@bdehamer bdehamer deleted the bdehamer/eslint-update branch December 16, 2024 15:08
@MyanmarHengXingDevelopment

40651240600742601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants