Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docker-compose and clean up the default runner #1924

Merged
merged 17 commits into from
Nov 25, 2022

Conversation

toast-gear
Copy link
Collaborator

At the moment the images aren't aligned in terms fo tooling and general format. This brings Docker Compose to the default runner.

@toast-gear
Copy link
Collaborator Author

waiting for #1759 to be merged before carrying on

@toast-gear toast-gear marked this pull request as ready for review November 19, 2022 10:31
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This passes my local E2E test run. LGTM!

@mumoshu mumoshu merged commit 87f566e into master Nov 25, 2022
@mumoshu mumoshu deleted the feat/align-runner-images-default branch November 25, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants