Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML page has non-empty title - #2779a5: updated Passed Example 2 description #2181

Merged

Conversation

giacomo-petri
Copy link
Collaborator

Closes: #2169

Changes:

  • updated "Passed Example 2" clarifying that the rule doesn't take into account HTML embedded page within the top level page.

Need for Call for Review:
This will require a 1 week Call for Review


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@giacomo-petri giacomo-petri self-assigned this Apr 11, 2024
@giacomo-petri giacomo-petri added the Review Call 1 week Call for review for small changes label Aug 1, 2024
@giacomo-petri
Copy link
Collaborator Author

1 week call for review ends on August 9th.

@WilcoFiers WilcoFiers merged commit b379b0c into develop Aug 30, 2024
2 checks passed
@WilcoFiers WilcoFiers deleted the giacomo-petri-2779a5-removed-passed-example-2-ambiguity branch August 30, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Call 1 week Call for review for small changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passed Example 2 of "HTML page has non-empty title" rule is quite ambiguous
5 participants