Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: Run prettier #2173

Merged
merged 1 commit into from
Apr 3, 2024
Merged

[chore]: Run prettier #2173

merged 1 commit into from
Apr 3, 2024

Conversation

Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Apr 3, 2024

Run prettier

Closes issue(s):

  • N/A

Need for Call for Review:
This will not require a Call for Review (just run prettier)


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@Jym77 Jym77 self-assigned this Apr 3, 2024
@Jym77 Jym77 mentioned this pull request Apr 3, 2024
7 tasks
@carlosapaduarte carlosapaduarte marked this pull request as ready for review April 3, 2024 16:10
@carlosapaduarte carlosapaduarte merged commit c73d235 into develop Apr 3, 2024
2 checks passed
@carlosapaduarte carlosapaduarte deleted the prettier branch April 3, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants