Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Set of Instruments Definition to have Objective=False #2069

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

tbostic32
Copy link
Collaborator

The definition for set of instruments has objective set to true, but relies on instrument and clearly labelled location which both have objective set to false, which I think should logically mean this definition isn't objective.

I do not believe that this definition is used in any place where it would need to be objective (i.e., the applicability) so I think it is fine to change.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Copy link
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is indeed only used in Expectations (and example description):

$ grep -l set-of-clearly-labeled-instruments pages/glossary/*.md _rules/*.md
pages/glossary/set-of-clearly-labeled-instruments.md
_rules/device-motion-disabled-c249d5.md
_rules/printable-characters-shortcut-ffbc54.md
$ grep -B5 "\[set of clearly labeled instruments]\[]" _rules/*.md
_rules/device-motion-disabled-c249d5.md-## Expectation
_rules/device-motion-disabled-c249d5.md-
_rules/device-motion-disabled-c249d5.md-For each registered [device orientation event][device orientation] or [device motion event][device motion] in the test target at least one of the following is true:
_rules/device-motion-disabled-c249d5.md-
_rules/device-motion-disabled-c249d5.md-- **no changes:** The registered event does not cause [changes to the content][changes in content] of the [web page][] within a 1 minute time span of the [event firing][event firing]; or
_rules/device-motion-disabled-c249d5.md:- **disabled:** There is at least one [set of clearly labeled instruments][] to [block the event][blocked event][] for at least 1 minute.
--
_rules/printable-characters-shortcut-ffbc54.md-
_rules/printable-characters-shortcut-ffbc54.md-## Expectation
_rules/printable-characters-shortcut-ffbc54.md-
_rules/printable-characters-shortcut-ffbc54.md-For each test target at least one of the following is true:
_rules/printable-characters-shortcut-ffbc54.md-
_rules/printable-characters-shortcut-ffbc54.md:- **disable/remap**: there is at least one [set of clearly labeled instruments][] to [block events][blocked event] that use the [same key][same key events] as the test target and whose `getModifierState` method returns `false` for each of the [valid modifier keys][]; or
--
_rules/printable-characters-shortcut-ffbc54.md-</html>
_rules/printable-characters-shortcut-ffbc54.md-```
_rules/printable-characters-shortcut-ffbc54.md-
_rules/printable-characters-shortcut-ffbc54.md-#### Passed Example 6
_rules/printable-characters-shortcut-ffbc54.md-
_rules/printable-characters-shortcut-ffbc54.md:This [HTML document][] is listening to [keyboard events][keyboard event] for which the attribute `key` is a [printable character][] and the method `getModifierState` returns `false`, and which cause [changes in content][]. There exists a [set of clearly labeled instruments][] to **disable** or to **remap** the [keyboard event][] so that [same key][same key events] events are [blocked][blocked event] unless `getModifierState("Control")` returns `true`.

@Jym77
Copy link
Collaborator

Jym77 commented Jun 29, 2023

Since this is just fixing an editorial mismatch, I don't think it needs a Call for Review. Merging now.

@Jym77 Jym77 merged commit 4f90e27 into develop Jun 29, 2023
1 check passed
@Jym77 Jym77 deleted the tbostic32/set_of_instrument branch June 29, 2023 10:00
Jym77 pushed a commit that referenced this pull request Oct 13, 2023
Jym77 added a commit that referenced this pull request Oct 16, 2023
…2125)

* Update programmatically-determined-link-context.md

* Update iframe-not-focusable-has-no-interactive-content-akn7bn.md

* Update programmatically-determined-link-context.md

* Update iframe-not-focusable-has-no-interactive-content-akn7bn.md

* Create modal-dialog

* Rename modal-dialog to modal-dialog.md

* Update iframe-not-focusable-has-no-interactive-content-akn7bn.md

* Update iframe-not-focusable-has-no-interactive-content-akn7bn.md

* Apply suggestions from code review

Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>

* Update iframe-not-focusable-has-no-interactive-content-akn7bn.md

* Update and rename modal-dialog.md to inert.md

* Update iframe-not-focusable-has-no-interactive-content-akn7bn.md

* Update iframe-not-focusable-has-no-interactive-content-akn7bn.md

* Update spelling-ignore.yml

* Update iframe-not-focusable-has-no-interactive-content-akn7bn.md

* Update inert.md

* Apply suggestions from code review

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>

* Update iframe-not-focusable-has-no-interactive-content-akn7bn.md

* Update inert.md

* Apply suggestions from code review

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* AGWG Updates (#2067)

* Add (alt="") for clarity on empty alt

* Resolve focus visible feedback

* Tweak contrast rules

* Tweak page title descriptive

* Fix tests

* Apply suggestions from code review

Co-authored-by: Trevor R. Bostic <32486143+tbostic32@users.noreply.github.com>

---------

Co-authored-by: Trevor R. Bostic <32486143+tbostic32@users.noreply.github.com>

* [cae760] Frame has non-empty accessible name (#2034)

* First pass in response to Feb 16 TF meeting

* typo

* Update _rules/iframe-non-empty-accessible-name-cae760.md

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update _rules/iframe-non-empty-accessible-name-cae760.md

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update _rules/iframe-non-empty-accessible-name-cae760.md

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update _rules/iframe-non-empty-accessible-name-cae760.md

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update _rules/iframe-non-empty-accessible-name-cae760.md

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Move note about frame to background

* Set height for frame

* Test wants alphabetical contributors

* Update _rules/iframe-non-empty-accessible-name-cae760.md

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Update _rules/iframe-non-empty-accessible-name-cae760.md

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Update _rules/iframe-non-empty-accessible-name-cae760.md

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Move note to background

---------

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Updating glossary definition. (#2069)

* Bump yaml and zx (#2056)

* Bump yaml and zx

Bumps [yaml](https://github.com/eemeli/yaml) to 2.2.2 and updates ancestor dependency [zx](https://github.com/google/zx). These dependencies need to be updated together.


Updates `yaml` from 1.10.2 to 2.2.2
- [Release notes](https://github.com/eemeli/yaml/releases)
- [Commits](eemeli/yaml@v1.10.2...v2.2.2)

Updates `zx` from 5.3.0 to 7.2.1
- [Release notes](https://github.com/google/zx/releases)
- [Commits](google/zx@5.3.0...7.2.1)

---
updated-dependencies:
- dependency-name: yaml
  dependency-type: indirect
- dependency-name: zx
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

* Trigger CLA?

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* new rule: ARIA required ID references exist (#2041)

* new rule: ARIA required ID references exist

* Address review comments

Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>

* Apply suggestions from code review

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Apply suggestions from code review

Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Update _rules/aria-required-id-references-in6db8.md

* Apply suggestions from code review

Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>

---------

Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>

* scrollable element: clarify the title (#2083)

* UpdateTableHeaderRule (#2074)

* UpdateTableHeaderRule

* Update table-header-cell-has-assigned-cells-d0f69e.md

* trigger test

* Update _rules/table-header-cell-has-assigned-cells-d0f69e.md

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

---------

Co-authored-by: Wilco Fiers <wilco.fiers@deque.com>
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Adds apostrophe to mark the possessive form (#2080)

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Focus visible rule: Fix typo (#2082)

* Contrast rules: Tweak background text (#2090)

* Tweak name / description of Scrollable element keyboard (#2092)

* Deprecate HTML page lang and xml:lang attributes have matching values (#2086)

* Deprecate HTML page lang and xml:lang attributes have matching values

* Apply suggestions from code review

Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>

---------

Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>

* Rephrase Applicability (#2079)

* Rename file (#2078)

* Move secondary requirement texts out of the background (#2060)

* Move secondary requirement texts out of the background

* Apply suggestions from code review

* fix test

* Fix failing test

* Secondary reqs on ARIA rules

* Update all secondary requirements

* Typos

* Fix failing tests

* Update _rules/link-non-empty-accessible-name-c487ae.md

Co-authored-by: Trevor R. Bostic <32486143+tbostic32@users.noreply.github.com>

* Tweaked the language some more

* Update rule design info for secondary requirements

* Fix tests

* Apply suggestions from code review

Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

---------

Co-authored-by: Trevor R. Bostic <32486143+tbostic32@users.noreply.github.com>
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* fix test on secondary requirements (#2102)

* fix test on secondary requirements

* More assertions

* Update _rules/aria-required-id-references-in6db8.md

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

---------

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Update dependencies (including act-tools) (#2103)

* fix test-assets not getting built right (#2104)

* Update element-lang-valid-de46e4.md (#2100)

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* fix the approve-rule action (#2105)

* Remove outdated accsupport note (#2111)

* "Element with lang attribute has valid language tag" [de46e4]: Updated Failed Examples 4 and 5 to reflect Applicability (#2094)

* Update element-lang-valid-de46e4.md

Updated Failed examples 4 and 5 to reflect applicability

* Apply suggestions from code review

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Update _rules/element-lang-valid-de46e4.md

Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>

---------

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>
Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>

* Text spacing rewrite (#1923)

* Add new letter-spacing rule and deprecate old one

* Add new word-spacing rule and deprecate old one

* Clean up assumptions

* Clean up

* Clean up

* Add new line-height rule and deprecate old one

* Replace old letter spacing version rather than deprecating it

* Replace old line height version rather than deprecating it

* Replace old word spacing version rather than deprecating it

* Target text nodes

* Improve background note

* Apply suggestion from review

* Clean up

* Target text nodes rather than their parents

* Target text nodes rather than their parents

* Add missing reference

* Update example

* Apply to parent of text nodes, not text nodes

* Apply suggestions from code review

Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>

* Typos

Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>

* Typos

---------

Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>

* "Meta viewport allows for zoom" (b4f0c3): Explicit meaning of 'has' (#1994)

* Explicit meaning of 'has'

* Improve expectation and examples

* Typo

* Improve algorithm description

Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>

* Rephrase expectations

* Streamline Applicability

* Typo

* Simplify expectations

---------

Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>

* Map Empty-heading rule to ARIA instead of WCAG (#2120)

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Deprecate 4.1.1 rules (#2117)

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com>
Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>
Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Trevor R. Bostic <32486143+tbostic32@users.noreply.github.com>
Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: HelenBurge <41951878+HelenBurge@users.noreply.github.com>
Co-authored-by: Wilco Fiers <wilco.fiers@deque.com>
Co-authored-by: Daniel Montalvo <49305434+daniel-montalvo@users.noreply.github.com>
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
Jym77 added a commit that referenced this pull request Oct 26, 2023
…2125)

* Update programmatically-determined-link-context.md

* Update iframe-not-focusable-has-no-interactive-content-akn7bn.md

* Update programmatically-determined-link-context.md

* Update iframe-not-focusable-has-no-interactive-content-akn7bn.md

* Create modal-dialog

* Rename modal-dialog to modal-dialog.md

* Update iframe-not-focusable-has-no-interactive-content-akn7bn.md

* Update iframe-not-focusable-has-no-interactive-content-akn7bn.md

* Apply suggestions from code review

Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>

* Update iframe-not-focusable-has-no-interactive-content-akn7bn.md

* Update and rename modal-dialog.md to inert.md

* Update iframe-not-focusable-has-no-interactive-content-akn7bn.md

* Update iframe-not-focusable-has-no-interactive-content-akn7bn.md

* Update spelling-ignore.yml

* Update iframe-not-focusable-has-no-interactive-content-akn7bn.md

* Update inert.md

* Apply suggestions from code review

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>

* Update iframe-not-focusable-has-no-interactive-content-akn7bn.md

* Update inert.md

* Apply suggestions from code review

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* AGWG Updates (#2067)

* Add (alt="") for clarity on empty alt

* Resolve focus visible feedback

* Tweak contrast rules

* Tweak page title descriptive

* Fix tests

* Apply suggestions from code review

Co-authored-by: Trevor R. Bostic <32486143+tbostic32@users.noreply.github.com>

---------

Co-authored-by: Trevor R. Bostic <32486143+tbostic32@users.noreply.github.com>

* [cae760] Frame has non-empty accessible name (#2034)

* First pass in response to Feb 16 TF meeting

* typo

* Update _rules/iframe-non-empty-accessible-name-cae760.md

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update _rules/iframe-non-empty-accessible-name-cae760.md

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update _rules/iframe-non-empty-accessible-name-cae760.md

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update _rules/iframe-non-empty-accessible-name-cae760.md

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update _rules/iframe-non-empty-accessible-name-cae760.md

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Move note about frame to background

* Set height for frame

* Test wants alphabetical contributors

* Update _rules/iframe-non-empty-accessible-name-cae760.md

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Update _rules/iframe-non-empty-accessible-name-cae760.md

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Update _rules/iframe-non-empty-accessible-name-cae760.md

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Move note to background

---------

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Updating glossary definition. (#2069)

* Bump yaml and zx (#2056)

* Bump yaml and zx

Bumps [yaml](https://github.com/eemeli/yaml) to 2.2.2 and updates ancestor dependency [zx](https://github.com/google/zx). These dependencies need to be updated together.


Updates `yaml` from 1.10.2 to 2.2.2
- [Release notes](https://github.com/eemeli/yaml/releases)
- [Commits](eemeli/yaml@v1.10.2...v2.2.2)

Updates `zx` from 5.3.0 to 7.2.1
- [Release notes](https://github.com/google/zx/releases)
- [Commits](google/zx@5.3.0...7.2.1)

---
updated-dependencies:
- dependency-name: yaml
  dependency-type: indirect
- dependency-name: zx
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

* Trigger CLA?

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* new rule: ARIA required ID references exist (#2041)

* new rule: ARIA required ID references exist

* Address review comments

Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>

* Apply suggestions from code review

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Apply suggestions from code review

Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Update _rules/aria-required-id-references-in6db8.md

* Apply suggestions from code review

Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>

---------

Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>

* scrollable element: clarify the title (#2083)

* UpdateTableHeaderRule (#2074)

* UpdateTableHeaderRule

* Update table-header-cell-has-assigned-cells-d0f69e.md

* trigger test

* Update _rules/table-header-cell-has-assigned-cells-d0f69e.md

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

---------

Co-authored-by: Wilco Fiers <wilco.fiers@deque.com>
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Adds apostrophe to mark the possessive form (#2080)

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Focus visible rule: Fix typo (#2082)

* Contrast rules: Tweak background text (#2090)

* Tweak name / description of Scrollable element keyboard (#2092)

* Deprecate HTML page lang and xml:lang attributes have matching values (#2086)

* Deprecate HTML page lang and xml:lang attributes have matching values

* Apply suggestions from code review

Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>

---------

Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>

* Rephrase Applicability (#2079)

* Rename file (#2078)

* Move secondary requirement texts out of the background (#2060)

* Move secondary requirement texts out of the background

* Apply suggestions from code review

* fix test

* Fix failing test

* Secondary reqs on ARIA rules

* Update all secondary requirements

* Typos

* Fix failing tests

* Update _rules/link-non-empty-accessible-name-c487ae.md

Co-authored-by: Trevor R. Bostic <32486143+tbostic32@users.noreply.github.com>

* Tweaked the language some more

* Update rule design info for secondary requirements

* Fix tests

* Apply suggestions from code review

Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

---------

Co-authored-by: Trevor R. Bostic <32486143+tbostic32@users.noreply.github.com>
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* fix test on secondary requirements (#2102)

* fix test on secondary requirements

* More assertions

* Update _rules/aria-required-id-references-in6db8.md

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

---------

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Update dependencies (including act-tools) (#2103)

* fix test-assets not getting built right (#2104)

* Update element-lang-valid-de46e4.md (#2100)

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* fix the approve-rule action (#2105)

* Remove outdated accsupport note (#2111)

* "Element with lang attribute has valid language tag" [de46e4]: Updated Failed Examples 4 and 5 to reflect Applicability (#2094)

* Update element-lang-valid-de46e4.md

Updated Failed examples 4 and 5 to reflect applicability

* Apply suggestions from code review

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Update _rules/element-lang-valid-de46e4.md

Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>

---------

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>
Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>

* Text spacing rewrite (#1923)

* Add new letter-spacing rule and deprecate old one

* Add new word-spacing rule and deprecate old one

* Clean up assumptions

* Clean up

* Clean up

* Add new line-height rule and deprecate old one

* Replace old letter spacing version rather than deprecating it

* Replace old line height version rather than deprecating it

* Replace old word spacing version rather than deprecating it

* Target text nodes

* Improve background note

* Apply suggestion from review

* Clean up

* Target text nodes rather than their parents

* Target text nodes rather than their parents

* Add missing reference

* Update example

* Apply to parent of text nodes, not text nodes

* Apply suggestions from code review

Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>

* Typos

Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>

* Typos

---------

Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>

* "Meta viewport allows for zoom" (b4f0c3): Explicit meaning of 'has' (#1994)

* Explicit meaning of 'has'

* Improve expectation and examples

* Typo

* Improve algorithm description

Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>

* Rephrase expectations

* Streamline Applicability

* Typo

* Simplify expectations

---------

Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>

* Map Empty-heading rule to ARIA instead of WCAG (#2120)

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Deprecate 4.1.1 rules (#2117)

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com>
Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>
Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Trevor R. Bostic <32486143+tbostic32@users.noreply.github.com>
Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: HelenBurge <41951878+HelenBurge@users.noreply.github.com>
Co-authored-by: Wilco Fiers <wilco.fiers@deque.com>
Co-authored-by: Daniel Montalvo <49305434+daniel-montalvo@users.noreply.github.com>
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants