fix(atomizer): match 's' usage for justify-content #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carriemorrison
requested review from
src-code,
redonkulus and
snyamathi
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
|
Given its very low usage, I'm ok being consistent and changing the value to match the other properties. I checked internally and we do not use this property. |
|
OK, So I went ahead and remove the old backwards compat rule from the code.... |
|
|
redonkulus
changed the title
redonkulus
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Hmm this is a fun one, we can't use
contentPosition.s = 'startsince it seems a long time back 's' was used for stretch instead ofstlike all the other properties.https://github.com/acss-io/atomizer/pull/451/files#diff-b791d16fb36949f46d3a573d06f9dfb355562781b8668369f35b746841cbf444R1551
Since this was just added, we could change the value to
sta, even though I dislike it...I'm not sure of a way we can be backwards compat and have consistency...