Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(atomizer): align0items incorrect values #455

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

carriemorrison
Copy link
Collaborator

@carriemorrison carriemorrison commented Jul 20, 2022

I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.


Description

Noticed an issue with align-items. https://www.w3.org/TR/css-align-3/#propdef-align-items

should be:

normal | stretch | <baseline-position> | [ <overflow-position>? <self-position> ]

How Has This Been Tested?

fixed:
Screen Shot 2022-07-20 at 3 56 14 PM

Previous prod and last change:
old

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

Review the following points, and put an x in all the boxes that apply. If you’re unsure about any of these, don’t hesitate to ask. We’re here to help!

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@vercel
Copy link

vercel bot commented Jul 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
acss-site ✅ Ready (Inspect) Visit Preview Jul 20, 2022 at 10:56PM (UTC)

@redonkulus redonkulus merged commit 05188b4 into acss-io:master Jul 20, 2022
@carriemorrison carriemorrison deleted the fixAlign branch August 18, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants