-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(atomizer): Add blend modes #422
Conversation
packages/atomizer/tests/atomizer.js
Outdated
@@ -1302,4 +1302,33 @@ describe('Atomizer()', function () { | |||
]); | |||
}); | |||
}); | |||
describe('Blend modes', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we are going to start adding tests for rules, we should create a new file called rules.js
and start adding them there. Then it can be a 1 to 1 relationship with the existing rules.js
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I guess we need to decide if its beneficial as @src-code had mentioned we aren't really testing anything new here, just the values added...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could probably automate the whole thing by looping through the entire rules.js file and running the test for each rule and creating a snapshot or something. I think all of this could be in a separate PR since we can do it for all rules at one time.
d073b4b
to
485d6ca
Compare
Just added the 2 extra modes for https://drafts.fxtf.org/compositing/#mix-blend-mode |
Add missing blend modes:
We only support 1
background-blend-mode
since atomic only supports 1 bg imageHow Has This Been Tested?
Ran atomizer as per the testing docs:
Also added a basic unit test.
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:
Checklist
Review the following points, and put an x in all the boxes that apply. If you’re unsure about any of these, don’t hesitate to ask. We’re here to help!
I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.