Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ga tracking id #30

Merged
merged 1 commit into from
May 29, 2022
Merged

add ga tracking id #30

merged 1 commit into from
May 29, 2022

Conversation

shirshanka
Copy link

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

Unit Test Results (build & test)

  69 files  ±0    69 suites  ±0   2m 37s ⏱️ -2s
313 tests ±0  313 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ffb746e. ± Comparison against base commit ef8f525.

swaroopjagadish
swaroopjagadish approved these changes May 29, 2022
View reviewed changes
Copy link

@swaroopjagadish swaroopjagadish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swaroopjagadish swaroopjagadish merged commit 4447967 into master May 29, 2022
kushagra-apptware pushed a commit that referenced this pull request Sep 11, 2024
@shirshanka @kushagra-apptware
add ga tracking id (#30)
731b002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swaroopjagadish swaroopjagadish swaroopjagadish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shirshanka @swaroopjagadish