Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send python coverage to codecov, remove buildpulse which was not helping #213

Merged
merged 12 commits into from
Mar 20, 2023

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

.github/workflows/coverage-report.yml Outdated Show resolved Hide resolved
.github/workflows/coverage-report.yml Outdated Show resolved Hide resolved
.github/workflows/coverage-report.yml Outdated Show resolved Hide resolved
@anshbansal anshbansal changed the title send python coverage to codecov wip - send python coverage to codecov Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@2ee6d4c). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #213   +/-   ##
=========================================
  Coverage          ?   74.75%           
=========================================
  Files             ?      350           
  Lines             ?    35141           
  Branches          ?        0           
=========================================
  Hits              ?    26268           
  Misses            ?     8873           
  Partials          ?        0           
Flag Coverage Δ
pytest-lint ∅ <0.00%> (?)
pytest-testIntegration 50.51% <0.00%> (?)
pytest-testIntegrationBatch1 36.25% <0.00%> (?)
pytest-testQuick 63.39% <0.00%> (?)
pytest-testSlowIntegration 32.71% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@anshbansal
Copy link
Collaborator Author

anshbansal commented Mar 17, 2023

Got this so far at https://app.codecov.io/gh/acryldata/datahub/tree/aseem-send-coverage/ at 04e5507
image

Need to compare with a932f52 after latest run happens

@anshbansal anshbansal closed this Mar 18, 2023
@anshbansal anshbansal reopened this Mar 18, 2023
@anshbansal anshbansal changed the title wip - send python coverage to codecov send python coverage to codecov, remove buildpulse which was not helping Mar 18, 2023
Copy link

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems fine.. have a question about the ci flag

secret: ${{ secrets.BUILDPULSE_SECRET_ACCESS_KEY }}
token: ${{ secrets.CODECOV_TOKEN }}
directory: .
fail_ci_if_error: true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this flag do?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case the code coverage fails to be sent this will fail this workflow

# https://github.com/marketplace/actions/buildpulse
uses: Workshop64/buildpulse-action@main
- name: Upload coverage to Codecov
if: ${{ matrix.python-version == '3.10' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and job != lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants