-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
send python coverage to codecov, remove buildpulse which was not helping #213
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
=========================================
Coverage ? 74.75%
=========================================
Files ? 350
Lines ? 35141
Branches ? 0
=========================================
Hits ? 26268
Misses ? 8873
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Got this so far at https://app.codecov.io/gh/acryldata/datahub/tree/aseem-send-coverage/ at Need to compare with a932f52 after latest run happens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall seems fine.. have a question about the ci flag
secret: ${{ secrets.BUILDPULSE_SECRET_ACCESS_KEY }} | ||
token: ${{ secrets.CODECOV_TOKEN }} | ||
directory: . | ||
fail_ci_if_error: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this flag do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case the code coverage fails to be sent this will fail this workflow
# https://github.com/marketplace/actions/buildpulse | ||
uses: Workshop64/buildpulse-action@main | ||
- name: Upload coverage to Codecov | ||
if: ${{ matrix.python-version == '3.10' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and job != lint
Checklist