Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename Cher SpokePool -> Soneium #876

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: Rename Cher SpokePool -> Soneium #876

wants to merge 6 commits into from

Conversation

pxrl
Copy link
Contributor

@pxrl pxrl commented Jan 28, 2025

No description provided.

nicholaspai
nicholaspai previously approved these changes Jan 28, 2025
@bmzig
Copy link
Contributor

bmzig commented Jan 28, 2025

The links in deployments/README.md are wrong, too. Might as well change those.

@GIgako19929
Copy link

This pull request includes several changes to rename the Cher_SpokePool contract to Soneium_SpokePool across multiple files. The most important changes involve updating the contract name, modifying comments to reflect the new name, and renaming related deployment scripts.

Renaming contract and related references:

Updating deployment scripts:

  • deploy/060_soneium_spokepool.ts: Renamed the deployment script from 060_deploy_cher_spokepool.ts to 060_soneium_spokepool.ts and updated the function tags and proxy deployment call to use the new contract name.

nicholaspai
nicholaspai previously approved these changes Jan 31, 2025
@melisaguevara
Copy link
Contributor

The links in deployments/README.md are wrong, too. Might as well change those.

Just noticed this. PR here: #877

@GIgako19929
Copy link

This pull request includes renaming the Cher_SpokePool contract to Soneium_SpokePool and updating all related references across multiple files. Below are the most important changes:

Contract Renaming:

Deployment Script Update:

  • deploy/060_soneium_spokepool.ts: Renamed the deployment script from 060_deploy_cher_spokepool.ts to 060_soneium_spokepool.ts and updated the deployment function to use Soneium_SpokePool instead of Cher_SpokePool. Also updated the tags to reflect the new contract name.

bmzig
bmzig previously approved these changes Feb 5, 2025
@pxrl pxrl dismissed stale reviews from bmzig and nicholaspai via 52fb81c February 5, 2025 15:14
deployments/deployments.json Outdated Show resolved Hide resolved
bmzig
bmzig previously approved these changes Feb 5, 2025
deploy/060_soneium_spokepool.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants