Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: L-01: Comment on setCrossDomainAdmin Edge Case #729

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Conversation

bmzig
Copy link
Contributor

@bmzig bmzig commented Nov 7, 2024

The ForwarderBase contract has the setCrossDomainAdmin function which changes the crossDomainAdmin state variable. This variable is used to give access control to almost all functions within the contract, including those that are meant to be used to complete L1->L3 message passing and asset transfers. When calling setCrossDomainAdmin, it is assumed that there are no outstanding operations that need to be passed to another chain. This is because when operations arrive at L2, the original sender of those is the old crossDomainAdmin and will be blocked from continuing further. In order to raise awareness about such behavior, consider documenting this edge case in the setCrossDomainAdmin function.

This PR adds a comment outlining this effect.

Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

contracts/chain-adapters/ForwarderBase.sol Outdated Show resolved Hide resolved
Co-authored-by: James Morris, MS <96435344+james-a-morris@users.noreply.github.com>
@bmzig bmzig changed the title improve: comment on setCrossDomainAdmin edge case improve: L-01: Comment on setCrossDomainAdmin Edge Case Nov 8, 2024
@bmzig bmzig marked this pull request as ready for review November 14, 2024 20:41
@bmzig bmzig merged commit e57dd27 into master Nov 15, 2024
9 checks passed
@bmzig bmzig deleted the 1124oz/l01 branch November 15, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants