-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: H-02 Forwarder and Withdrawal Helper Contracts do not Handle ETH Transfers #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
This was referenced Nov 6, 2024
Signed-off-by: bennett <bennett@umaproject.org>
bmzig
changed the title
fix: support native token bridging in the forwarder/withdrawal helper
fix: H-02 Forwarder and Withdrawal Helper Contracts do not Handle ETH Transfers
Nov 8, 2024
Signed-off-by: bennett <bennett@umaproject.org>
nicholaspai
approved these changes
Nov 14, 2024
pxrl
approved these changes
Nov 14, 2024
@bmzig If you merge in the latest change from master you'll get a fix from Reinis that addresses the SVM test failure. |
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
receive
to bothForwarderBase
andWithdrawalHelperBase
so that it can receive native token transfers from L1 or L3 bridges. Both theForwarderBase
andWithdrawalHelperBase
now contain a hook named_wrapNativeToken
which is called whenever a L2-L3 bridge or withdrawal which includes the L2's native token is initiated on the respective contracts. Both theForwarderBase
andWithdrawalHelperBase
now take an additional argument_wrappedNativeToken
in their constructor, which is used to deposit the native token in the_wrapNativeToken
hook.