Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(svm): comment to explain setEnableRoute conversion #696

Merged
merged 2 commits into from
Oct 28, 2024
Merged

docs(svm): comment to explain setEnableRoute conversion #696

merged 2 commits into from
Oct 28, 2024

Conversation

md0x
Copy link
Contributor

@md0x md0x commented Oct 28, 2024

Changes proposed in this PR:

  • Add comment to explain the setEnableRoute function signature translation

@md0x
docs(svm): comment to explain setEnableRoute conversion
10fac31 
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
@linear Linear
Copy link

linear bot commented Oct 28, 2024

ACX-2933 instructions/handle_receive_message.rs: Make sure to change EVM SpokePool interface using bytes32 for token addresses and uint64 for chain IDs.

@md0x md0x requested review from chrismaree and Reinis-FRP October 28, 2024 10:01
@md0x @Reinis-FRP
Update programs/svm-spoke/src/instructions/handle_receive_message.rs
9acb3c7 
Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com>
@md0x md0x merged commit 4238084 into master Oct 28, 2024
9 checks passed
@md0x md0x deleted the pablo/acx-2933-instructionshandle_receive_messagers-make-sure-to-change-evm branch October 28, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reinis-FRP Reinis-FRP Reinis-FRP left review comments

@chrismaree chrismaree chrismaree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@md0x @chrismaree @Reinis-FRP