refactor(UBA): sideload HRE environment variable #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-a-morris
force-pushed
the
james/acx-1166-resolve-scraper-hardhat-error-on-initialization
branch
from
b2c3c8d to
f765362
Compare
mrice32
approved these changes
May 26, 2023
There was a problem hiding this comment.
LGTM! Great fix, @james-a-morris!
Two other concerns that are pre-existing, but I noticed when reading through this PR (Note: I don't think we need to worry about these now or in this PR, but they might come up in the future):
- We're exporting test utils (things that use chai, etc). This is a bit weird, and probably means we have to include test libraries like chai or hardhat in our regular dependencies and not dev dependencies. That won't break anything, but it increases the size of the exported package and is pretty nonstandard for a package meant to be used in production applications.
- In some of these utilities, we're importing nodejs-specific packages that will break if imported into a FE. These include path, and fs. I'm not sure if this is problematic today, but might end up causing breakages in the future.
I think this is good to go as is and we can worry about those others in the future if/when we need to!
This change essentially side-loads the HRE variables to prevent the need to directly interface with the Hardhat Runtime Environment. Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
james-a-morris
force-pushed
the
james/acx-1166-resolve-scraper-hardhat-error-on-initialization
branch
from
25a0089 to
fe3dde2
Compare
nicholaspai
approved these changes
May 30, 2023
james-a-morris
deleted the
james/acx-1166-resolve-scraper-hardhat-error-on-initialization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change essentially side-loads the HRE variables to prevent the need to directly interface with the Hardhat Runtime Environment.