improve(SpokePool): Optimize which params are indexed
#250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`FundsDeposited` and `FilledRelay` should index on `originChainId`/`destinationChainid` and `depositId` since this is all thats needed to uniquely identify a deposit. This would make the relayer's job easier for certain functions like looking up a specific deposit for a fill, if it knows which `SpokePool` contract to look up events on, it can index on `depositId` and `destinationChainId` to efficiently find the deposit. Conversely, if looking up a fill for a deposit, then the relayer would want to index on `originChainId` and `depositId` assuming it knows which `SpokePool` was the destination one and is the one it needs to query events on. See [this](https://github.com/across-protocol/relayer-v2/blob/master/src/clients/SpokePoolClient.ts#L316) comment for example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be safe to merge post-audit since it only affects event params
indexedproperty.FundsDepositedandFilledRelayshould index onoriginChainId/destinationChainidanddepositIdsince this is all thats needed to uniquely identify a deposit.This would make the relayer's job easier for certain functions like looking up a specific deposit for a fill, if it knows which
SpokePoolcontract to look up events on, it can index ondepositIdanddestinationChainIdto efficiently find the deposit.Conversely, if looking up a fill for a deposit, then the relayer would want to index on
originChainIdanddepositIdassuming it knows whichSpokePoolwas the destination one and is the one it needs to query events on.See this comment for example