Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACMS-3647: Add helper function to get segmented Acquia environment names. #84

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

rajeshreeputra
Copy link
Contributor

@rajeshreeputra rajeshreeputra commented Mar 8, 2024

Fixes #ACMS-3647

Motivation

Currently environment detector does not group the environments, hence proposed new method to group it.

Proposed changes

Segment the environments, like below:

  • prod or 01live, segmented by prod
  • stage, test, stg, 01test, segmented by stage
  • dev, 01dev, segmented by dev
  • ode01, ode02, ode.., segmented by ode

Alternatives considered

How else could the original issue / use case be addressed? Why did you choose this solution over any others?

Testing steps

How can we replicate the issue and verify that this PR fixes it?

@rajeshreeputra rajeshreeputra force-pushed the ACMS-3417 branch 2 times, most recently from 57493bf to aad2999 Compare March 13, 2024 03:54
@rajeshreeputra rajeshreeputra changed the title ACMS-3417: Add helper function to get segmented Acquia environment names. ACMS-3647: Add helper function to get segmented Acquia environment names. Mar 13, 2024
@danepowell danepowell added the enhancement New feature or request label Jun 25, 2024
@danepowell
Copy link
Contributor

I'm happy to merge this if you get tests passing.

@rajeshreeputra
Copy link
Contributor Author

I'm happy to merge this if you get tests passing.

All tests are passing now.

@danepowell danepowell enabled auto-merge (squash) June 26, 2024 18:50
@danepowell danepowell merged commit 8644c92 into acquia:main Jun 27, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants