Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1245: Use REMOTEIDE_LABEL to bypass API call #1665

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Jan 22, 2024

Motivation

This API call is unnecessary. More importantly, it makes QA of IDE changes difficult because it's the only API call to the IDE endpoint associated with IDE creation.

Proposed changes

Use REMOTEIDE_LABEL instead of calling the API.

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. Run ide:wizard in a new IDE, see that an SSH key is created successfully with the same label as before.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (682129a) 91.33% compared to head (f9d8536) 91.32%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1665      +/-   ##
============================================
- Coverage     91.33%   91.32%   -0.01%     
- Complexity     1784     1785       +1     
============================================
  Files           122      122              
  Lines          6439     6434       -5     
============================================
- Hits           5881     5876       -5     
  Misses          558      558              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell danepowell merged commit dcb40ed into acquia:main Jan 23, 2024
12 checks passed
@danepowell danepowell deleted the CLI-1245 branch September 20, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant