Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to acquia/drupal-recommended-project #4168

Merged
merged 21 commits into from
Jul 9, 2020

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Jun 8, 2020

@danepowell
Copy link
Contributor Author

danepowell commented Jun 8, 2020

I think the remaining problem here is that ORCA runs git clean -df, which kills the docroot/sites/all directory because docroot/sites/all/files is not gitignored in acquia/drupal-recommended-project, as it was in blt-project.

Another more serious question is why the BLT tests are sensitive to that. It seems that they have traditionally keyed off "all" as a valid multisite, which probably isn't good. And when they use "default" (which is probably actually right) everything falls apart, seemingly because Drush interprets "default" as a valid URI and doesn't read the actual URI from local.drush.yml. (I created a ticket for this)

@danepowell
Copy link
Contributor Author

depends on acquia/drupal-recommended-project#4

@danepowell danepowell changed the title Fix missing ci.blt.yml for ORCA tests. Switch to acquia/drupal-recommended-project Jun 8, 2020
@danepowell
Copy link
Contributor Author

This is pulling in the new project template version, but throwing the same error...

@danepowell danepowell merged commit b8c9f4d into acquia:12.x Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant