-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running blt setup fails #2251
Comments
I am installing it myself in the UI now. Got the same error:
|
This looks like an old bug with Lightning, not BLT. What version of Lightning are you using? Try using the latest release (2.2.3). I would not recommend installing via the UI if you are using BLT, as it's not as reproducible across environments, and BLT performs other actions (like config imports) during an install. |
It looks like the latest release to me. I created the project a few times
with composer and keep winding up at that error in the console and in the
UI.
…On Fri, Nov 3, 2017 at 5:59 PM Dane Powell ***@***.***> wrote:
This looks like an old bug with Lightning, not BLT. What version of
Lightning are you using? Try using the latest release (2.2.3).
I would not recommend installing via the UI if you are using BLT, as it's
not as reproducible across environments, and BLT performs other actions
(like config imports) during an install.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2251 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAWGwBmZFj0-SrgOV2VZX2wN2BmnTdaZks5sy4zHgaJpZM4QRlvv>
.
|
Will have to check when I’m at a computer
…On Fri, Nov 3, 2017 at 6:00 PM Kevin Quillen ***@***.***> wrote:
It looks like the latest release to me. I created the project a few times
with composer and keep winding up at that error in the console and in the
UI.
On Fri, Nov 3, 2017 at 5:59 PM Dane Powell ***@***.***>
wrote:
> This looks like an old bug with Lightning, not BLT. What version of
> Lightning are you using? Try using the latest release (2.2.3).
>
> I would not recommend installing via the UI if you are using BLT, as it's
> not as reproducible across environments, and BLT performs other actions
> (like config imports) during an install.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#2251 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AAWGwBmZFj0-SrgOV2VZX2wN2BmnTdaZks5sy4zHgaJpZM4QRlvv>
> .
>
|
I tried this on a completely new machine (macOS High Sierra this time) and get the same result. Everything is up to date.
The version of Lightning according to the profile info file is 2.23. This looks like the newest version. |
Thanks for trying to reproduce on a fresh install. I just did the same thing and it worked fine for me, so I'm wondering what's different about your setup. For one thing, a fresh BLT project should not have any configuration in
Yet, it appears that on your install it is trying to import configuration. Do you know where that config is coming from? |
The config directory only has ci and default, both folders are empty. |
Actually I now see the warning in your log, so that's not it. I've tested this several times locally, and we also test this exact project creation process in all of our automated tests, and I've never seen this. Very perplexing. Can you post the output of the composer create-project command? It might be easier to attach it or use a pastebin or something, since it's probably quite large. |
Here's the composer create-project output:
|
That all looks normal. Right now I don't see anything that would explain this weird behavior. I'll have to think about this. |
Everything else seems up to date, its 8.4.2 core, Drupal VM 4.3... I don't really get it. |
I am seething the same thing on 9.1.x with no changes to default BLT config. (Installing the
|
This seems relevant, although I can't understand how it would apply to a completely new project: https://github.com/acquia/lightning/issues/509 |
This is a shot in the dark... are you using the latest Composer version (1.5.2)? If not maybe try upgrading. This seems vaguely similar to the Lightning issue, which was a Composer-related bug (config-related core patch not being applied) |
Yep, composer 1.5.2. First thing I tried upgrading.
…On Mon, Nov 6, 2017 at 12:47 PM, Dane Powell ***@***.***> wrote:
This is a shot in the dark... are you using the latest Composer version
(1.5.2)? If not maybe try upgrading.
This seems vaguely similar to the Lightning issue, which was a
Composer-related bug (config-related core patch not being applied)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2251 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAWGwI6r4wyGDC0zGIVa9wlidRSyuTXSks5sz0ZEgaJpZM4QRlvv>
.
|
That issue seems like it eventually worked for 8.4.1, but I have 8.4.2.
On Mon, Nov 6, 2017 at 12:48 PM, Kevin Quillen <kevinquillen@gmail.com>
wrote:
… Yep, composer 1.5.2. First thing I tried upgrading.
On Mon, Nov 6, 2017 at 12:47 PM, Dane Powell ***@***.***>
wrote:
> This is a shot in the dark... are you using the latest Composer version
> (1.5.2)? If not maybe try upgrading.
>
> This seems vaguely similar to the Lightning issue, which was a
> Composer-related bug (config-related core patch not being applied)
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#2251 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AAWGwI6r4wyGDC0zGIVa9wlidRSyuTXSks5sz0ZEgaJpZM4QRlvv>
> .
>
|
Can you confirm that this directory has exactly two files? My suspicion is that this patch is not being applied by composer, though I have no idea why yet. Maybe also upgrade any global plugins you are using? Rest assured you are not the only person with this problem, more people are experiencing it now. We're just not sure why. |
|
Not sure if related to this specifically, but want to flag. There are some pretty major issues with composer patches that impact the way lightning gets installed. https://github.com/acquia/lightning/issues/473 |
Hmm... I too have an open issue about composer patches not always applying
and in some cases outright ignored.
…On Mon, Nov 6, 2017 at 1:28 PM, Grant Gaudet ***@***.***> wrote:
Not sure if related to this specifically, but want to flag. There are some
pretty major issues with composer patches that impact the way lightning
gets installed.
acquia/lightning#473 <https://github.com/acquia/lightning/issues/473>
cweagans/composer-patches#148
<cweagans/composer-patches#148>
cweagans/composer-patches#152
<cweagans/composer-patches#152>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2251 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAWGwKF9LwAxLCR5tfRcP9mfUggvfhTcks5sz0-4gaJpZM4QRlvv>
.
|
Okay so this almost certainly a composer-patches bug then, if that patch is not being applied on a clean install. It's been suggested to me to try clearing composer caches multiple times before creating a new project, try that. |
`composer clear-cache`? Yep, I had done that twice as well on both machines.
…On Mon, Nov 6, 2017 at 1:32 PM, Dane Powell ***@***.***> wrote:
Okay so this almost certainly a composer-patches bug then, if that patch
is not being applied on a clean install.
It's been suggested to me to try clearing composer caches multiple times
before creating a new project, try that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2251 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAWGwBlKXYkp7JId21SOvd6jK16OoC1Lks5sz1DJgaJpZM4QRlvv>
.
|
Here is the issue I opened a while back as well: cweagans/composer-patches#145 |
In my local testing, it appears that the patch in https://www.drupal.org/node/2883813 should be failing to apply against Drupal 8.4.2, and composer-patches is not reporting the failure. [2017-11-06 11:38:47] $ git apply -v 2883813-27.patch
Checking patch core/modules/hal/tests/src/Functional/EntityResource/Media/MediaHalJsonAnonTest.php...
Checking patch core/modules/media/tests/modules/media_test_type/media_test_type.info.yml...
error: while searching for:
package: Testing
version: VERSION
dependencies:
- media_test_source
error: patch failed: core/modules/media/tests/modules/media_test_type/media_test_type.info.yml:5
error: core/modules/media/tests/modules/media_test_type/media_test_type.info.yml: patch does not apply |
Hi @jrbeeman,
|
I am also experiencing this issue. Do we have a recommended resolution for now? Use an earlier version of Lightning? Edit: I resolved the issue by rolling back to Git 2.13.4, as per this composer-patches issue. Doing so with Homebrew isn't obvious, so here's how you do it (assuming you've already installed Git via Homebrew):
|
tl;dr: I've found a better fix, though probably not the best (which would be to fix composer-patch): I've been testing this on an Ubuntu and Mac machine. Both are running Composer 1.5.2 and Git 2.15.0. I was able to reproduce this only on the Mac. I noticed that Mac has a very old version of GNU patch installed by default (2.5). Ubuntu uses 2.7.5. Upgrading the version of GNU patch on Mac to 2.7.5 like Ubuntu solved this. |
Wow, if this is true what a great find. I’ll have to give it a whirl.
…On Tue, Nov 7, 2017 at 7:03 PM Dane Powell ***@***.***> wrote:
tl;dr: I've found a better fix, though probably not the *best* (which
would be to fix composer-patch):
brew install gpatch then restart your terminal
I've been testing this on an Ubuntu and Mac machine. Both are running
Composer 1.5.2 and Git 2.15.0. I was able to reproduce this only on the Mac.
I noticed that Mac has a very old version of GNU patch installed by
default (2.5). Ubuntu uses 2.7.5. Upgrading the version of GNU patch on Mac
to 2.7.5 like Ubuntu solved this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2251 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAWGwEtcOZEhKVlkKhzy7LhBWwxy6kp9ks5s0O_hgaJpZM4QRlvv>
.
|
Excellent work!
…On Wed, Nov 29, 2017 at 5:11 PM Dane Powell ***@***.***> wrote:
Closed #2251 <#2251> via #2319
<#2319>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2251 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAWGwHBnYWE-PKNhatVXz52nayjPrqFzks5s7dZ8gaJpZM4QRlvv>
.
|
I've also recommended that Lightning require the new version: acquia/lightning#524 |
Ugh, I really hate to reopen this, but it looks like this might not be a complete fix: acquia/lightning#524 (comment) |
My system information:
Output of
blt doctor
:When I run this command:
I get the following output:
And I expected this to happen:
Drupal 8 to install.
I have destroyed the VM and started from scratch many times today and always wind up back in this same spot.
VM config:
I am not doing anything different than I normally do, but this is my first time using Lightning.
The text was updated successfully, but these errors were encountered: