Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added power support #985

Closed
wants to merge 3 commits into from
Closed

Added power support #985

wants to merge 3 commits into from

Conversation

dthadi3
Copy link

@dthadi3 dthadi3 commented Oct 6, 2020

Thanks for your code, Its working good. Added power support for the travis.yml file with ppc64le. This is part of the Ubuntu distribution for ppc64le. This helps us simplify testing later when distributions are re-building and re-releasing. For more info tag @gerrith3.

@marijnh
Copy link
Member

marijnh commented Oct 6, 2020

I have never ran into a situation where a node.js program worked on one architecture but not on another, so at first glance, this looks like a waste of Travis CPU time. Can you elaborate on the motivation here?

@gerrith3
Copy link

gerrith3 commented Nov 3, 2020

@marijnh Actually, we have an automation test where we've tried to test about 100,000 npms, with initially about a 20-25% failure rate. It is hard to tell which ones will work and which won't without the testing. Most fail in the build or testing due to challenges in things like electron/phantomjs/chromedriver not installed by default, or packages which depend on older versions of npm (minor), etc. Explicit testing removes that question completely. BTW, many of the failures are reasonably easy to correct when we know about them.

@marijnh
Copy link
Member

marijnh commented Nov 3, 2020

Fair enough, but no, I don't want to continue burning CI cycles for every patch in the off chance that this regresses in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants