Skip to content

Commit

Permalink
Removing Chakra specific hack from JSIExecutor (facebook#66)
Browse files Browse the repository at this point in the history
  • Loading branch information
mganandraj authored and acoates-ms committed May 15, 2019
1 parent 8a1b084 commit 14729ed
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -97,15 +97,11 @@ void JSIExecutor::loadApplicationScript(

// TODO: check for and use precompiled HBC

// ChakraCore implementation of JSI don't yet support HostObjects.
// https://office.visualstudio.com/OC/_workitems/edit/2801906
#if !defined(CHAKRA_JSI)
runtime_->global().setProperty(
*runtime_,
"nativeModuleProxy",
Object::createFromHostObject(
*runtime_, std::make_shared<NativeModuleProxy>(*this)));
#endif

runtime_->global().setProperty(
*runtime_,
Expand Down

0 comments on commit 14729ed

Please sign in to comment.