Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4836 (Switch to new Gandi LiveDNS API) #4948

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

rparenton
Copy link
Contributor

  1. Updated LiveDNS API URL for the new API to allow Personal Access Tokens to work
  2. Updated authorization header syntax to allow deprecated API Keys to work with the new API
  3. Removed white space in JSON response parsing to match responses returned by the server

1. Updated LiveDNS API URL for the new API to allow Personal Access Tokens to work
2. Updated authorization header syntax to allow deprecated API Keys to work with the new API
3. Removed white space in JSON response parsing to match responses returned by the server
Copy link

Welcome
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@rparenton
Copy link
Contributor Author

All CI tests passed

@Neilpang Neilpang merged commit 1905830 into acmesh-official:dev Jan 14, 2024
14 checks passed
@rparenton rparenton deleted the gandi-livedns-new-api branch January 14, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants