Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary eval #4662

Closed
wants to merge 2 commits into from
Closed

Avoid unnecessary eval #4662

wants to merge 2 commits into from

Conversation

soliton-
Copy link

@soliton- soliton- commented Jun 9, 2023

This removes unnecessary eval calls. (Originally triggered by #4659)

@soliton- soliton- changed the title Patch 2 Avoid unnecessary eval Jun 9, 2023
@Neilpang
Copy link
Member

Neilpang commented Jun 9, 2023

please update to the latest dev code, and fix the conflicts first.

@soliton-
Copy link
Author

soliton- commented Jun 9, 2023

Well, looks like the _exec function is gone now so no more point in this.

@Neilpang
Copy link
Member

Neilpang commented Jun 9, 2023

it was for displaying error messages. so, just remove them.

@Neilpang Neilpang closed this Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soliton- @Neilpang