Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added functionality for Palo Alto Firewall deployments (PANOS) #4575

Merged
merged 17 commits into from
Jul 30, 2023
Merged

Added functionality for Palo Alto Firewall deployments (PANOS) #4575

merged 17 commits into from
Jul 30, 2023

Conversation

sg1888
Copy link

@sg1888 sg1888 commented Mar 31, 2023

This resolves #4309 (wildcard certs) as well as issues deploying ecc certificates to Palo Alto firewalls. Wildcard certificates will now have their asterisk * replaced with WILDCARD_ on the firewall.

Ex: The certificate *.mydomain.com will be saved as WILDCARD_.mydomain.com on PanOS.

sg1888
sg1888 commented Apr 12, 2023
View reviewed changes
Copy link
Author

@sg1888 sg1888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added ability to save and reuse API key rather than regenerating a new key on every deployment.

@sg1888
Copy link
Author

sg1888 commented Apr 19, 2023

@Neilpang - can you pls merge this into the dev branch?

@Neilpang
Copy link
Member

fix the ci errors first

@sg1888
Copy link
Author

sg1888 commented Apr 24, 2023

fix the ci errors first

@Neilpang - Made the changes.

@sg1888 sg1888 changed the title Panos ecc fix Added new functionality for Palo Alto Firewall deployments May 17, 2023
@sg1888 sg1888 changed the title Added new functionality for Palo Alto Firewall deployments Added functionality for Palo Alto Firewall deployments (PANOS) May 17, 2023
@sg1888
Copy link
Author

sg1888 commented May 30, 2023

@Neilpang - Can you please run the checks on the latest code? I believe the latest code should pass the CI checks.

Thank you.

@sg1888
Copy link
Author

sg1888 commented Jun 14, 2023

@Neilpang - Hi Neil - any updates on the pull request? There have been a few people looking for wildcard cert functionality on PanOS. Right now wildcard cert deployments fail with PANOS without any clear explanation as to the reason (it's the '*' in the filename). Let me know if there are any additional questions you have on the code.

Thanks!

@sg1888
Copy link
Author

sg1888 commented Jul 7, 2023

@Neilpang - Checking in to see if you've had a chance to review the PR. Any thoughts / comments?

Neilpang
Neilpang reviewed Jul 8, 2023
View reviewed changes
deploy/panos.sh Outdated Show resolved Hide resolved
@sg1888
Copy link
Author

sg1888 commented Jul 12, 2023

The latest update also resolves #4197 and incorporates changes made by @Hossy at #4198

@sg1888 sg1888 mentioned this pull request Jul 18, 2023
Open
@sg1888
Copy link
Author

sg1888 commented Jul 19, 2023

@Neilpang - Can you please merge these to the dev branch?

@sg1888 sg1888 mentioned this pull request Jul 20, 2023
Open
@Neilpang Neilpang merged commit 56cf93d into acmesh-official:dev Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neilpang Neilpang Neilpang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sg1888 @Neilpang