deploy/routeros.sh fixes #3947
Merged
deploy/routeros.sh fixes #3947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to modify ssh/scp commands make them configurable via environment variables. Signed-off-by: Andreas Bießmann <andreas@biessmann.org>
As the script is applying the fullchain which includes three certificates, delete all of them before applying updated certificate. Signed-off-by: Andreas Bießmann <andreas@biessmann.org>
This set the owner of script to ssh user, have the comment line in script as real comment and removes policy since this is set from current user, at least for RouterOS 7.x. Signed-off-by: Andreas Bießmann <andreas@biessmann.org>
abiessmann
force-pushed
the
deploy_routeros_fixes
branch
from
472a007 to
c46ceb0
Compare
|
Just saw another change in dev ... @mac-zhou introduced ROUTER_OS_PORT which was not in my base ... need to discuss if we stick with ROUTER_OS_PORT and ROUTER_OS_SSH_CMD/ROUTER_OS_SCP_CMD variables or to kick ROUTER_OS_PORT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to deploy/routeros.sh:
scpandsshconfigurable to set specific parameters to those commands